Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] xorg-3.eclass: EAUTORECONF_DEPENDS belong to BDEPEND
Date: Thu, 13 Jun 2019 12:45:50
Message-Id: 20190613134522.75028960@symphony.aura-online.co.uk
In Reply to: [gentoo-dev] [PATCH] xorg-3.eclass: EAUTORECONF_DEPENDS belong to BDEPEND by Michael Haubenwallner
1 On Thu, 13 Jun 2019 13:08:15 +0200
2 Michael Haubenwallner <haubi@g.o> wrote:
3
4 > EAUTORECONF_DEPENDS is non-empty for ppc-aix and x86-winnt only.
5 > Also, unset variable 'arch' after use.
6 > ---
7 > eclass/xorg-3.eclass | 3 ++-
8 > 1 file changed, 2 insertions(+), 1 deletion(-)
9 >
10 > diff --git a/eclass/xorg-3.eclass b/eclass/xorg-3.eclass
11 > index 6ac90a64d59..f135058fba6 100644
12 > --- a/eclass/xorg-3.eclass
13 > +++ b/eclass/xorg-3.eclass
14 > @@ -116,7 +116,8 @@ WANT_AUTOMAKE="latest"
15 > for arch in ${XORG_EAUTORECONF_ARCHES}; do
16 > EAUTORECONF_DEPENDS+=" ${arch}? ( ${EAUTORECONF_DEPEND} )"
17 > done
18 > -DEPEND+=" ${EAUTORECONF_DEPENDS}"
19 > +unset arch
20 > +BDEPEND+=" ${EAUTORECONF_DEPENDS}"
21 > [[ ${XORG_EAUTORECONF} != no ]] && BDEPEND+=" ${EAUTORECONF_DEPEND}"
22 > unset EAUTORECONF_DEPENDS
23 > unset EAUTORECONF_DEPEND
24
25 Apart from the unset, the comment doesn't seem to relate to the actual
26 change?
27
28 --
29 James Le Cuirot (chewi)
30 Gentoo Linux Developer

Replies