Archives
Archives
| From: | Mike Frysinger <vapier@g.o> | ||
|---|---|---|---|
| To: | Leno Hou <lenohou@×××××.com> | ||
| Cc: | alex_y_xu@×××××.ca, gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev][PATCH v1 ] sys-fs/hfsplusutils with gcc-5: blockiter.c:148:8: error: redefinition of blockiter_curr #580620 | ||
| Date: | Sat, 23 Apr 2016 06:39:27 | ||
| Message-Id: | 20160423063916.GK5369@vapier.lan | ||
| In Reply to: | [gentoo-dev][PATCH v1 ] sys-fs/hfsplusutils with gcc-5: blockiter.c:148:8: error: redefinition of blockiter_curr #580620 by Leno Hou |
||
| 1 | On 22 Apr 2016 03:57, Leno Hou wrote: |
| 2 | > +-extern inline UInt32 blockiter_curr(blockiter *b) |
| 3 | > +-{ |
| 4 | > +- return b->e->start_block + b->block; |
| 5 | > +-} |
| 6 | > +- |
| 7 | > +- |
| 8 | > ++extern inline UInt32 blockiter_curr(blockiter *b); |
| 9 | |
| 10 | i don't think that's how you want to handle extern inline. |
| 11 | it doesn't make sense when it's declared this way as there |
| 12 | is no actual body for gcc to optimisitcally inline. |
| 13 | |
| 14 | instead, we should go with what Ubuntu/Debian have: use the |
| 15 | -fgnu89-inline flag to build since those are the semantics |
| 16 | this code expects. i've pushed that fix now. |
| 17 | -mike |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev][PATCH v1 ] sys-fs/hfsplusutils with gcc-5: blockiter.c:148:8: error: redefinition of blockiter_curr #580620 | David Seifert <soap@g.o> |