1 |
On 20:49 Sun 02 Nov , Donnie Berkholz wrote: |
2 |
> On 00:08 Mon 03 Nov , Peter Alfredsen wrote: |
3 |
> > +case "${EAPI}" in |
4 |
> > + 2) |
5 |
> > + EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_install |
6 |
> > + ;; |
7 |
> > + *) |
8 |
> > + EXPORT_FUNCTIONS src_unpack src_compile src_install |
9 |
> > + ;; |
10 |
> > +esac |
11 |
> > + |
12 |
> |
13 |
> This eclass needs to do the same thing as the other eclasses that got |
14 |
> EAPI=2 patches and default EAPI to 0 when it's not defined, everywhere |
15 |
> where it tests the value of EAPI. |
16 |
|
17 |
Yeah, I realize it might technically work, but it's just asking for |
18 |
breakage in my opinion. Better to be explicit and have the '*' case be |
19 |
for something unexpected instead of an expected case. |
20 |
|
21 |
-- |
22 |
Thanks, |
23 |
Donnie |
24 |
|
25 |
Donnie Berkholz |
26 |
Developer, Gentoo Linux |
27 |
Blog: http://dberkholz.wordpress.com |