Gentoo Archives: gentoo-dev

From: "Tomáš Chvátal" <scarabeus@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [RFC] check-reqs.eclass.patch
Date: Wed, 31 Aug 2011 15:09:15
Message-Id: 4E5E4E37.6030002@gentoo.org
In Reply to: Re: [gentoo-dev] [RFC] check-reqs.eclass.patch by "Michał Górny"
1 Dne 31.8.2011 14:38, Michał Górny napsal(a):
2 > On Wed, 31 Aug 2011 12:32:03 +0200
3 > Tomáš Chvátal<scarabeus@g.o> wrote:
4 >
5 >>> gibibytes, mebibytes, tebibytes.
6 >>>
7 >> I preffer binary units over this fancy standard :)
8 >> Even our tools return the binary calculated ones not the decadic ones.
9 >
10 > These are binary units, rather those fancy misnamed binary units of
11 > yours. It's not fancy standard, it's the ONLY standard :P.
12 >
13 >> # @ECLASS-VARIABLE: CHECKREQS_DISK_USR
14 >> # @DEFAULT_UNSET
15 >> # @DESCRIPTION:
16 >> # How much space in /usr is needed to install the package? (2T)
17 >
18 > Not this looks like a insane default :D.
19 >
20 >> [G]) echo $((1024 * ${size})) ;;
21 >
22 > just 'G)', 'M)', 'T)'.
23 >
24 >> ebegin "Checking for at least ${sizeunit} ${3}"
25 >
26 > What ${3} there? I think you should decide whether to name all vars, or
27 > use numeric ones.
28 >
29 >> # @FUNCTION: check-reqs_unsattisfied
30 >
31 > docstring not updated.
32 >
33 How about now?

Attachments

File name MIME type
check-reqs.eclass text/plain

Replies

Subject Author
Re: [gentoo-dev] [RFC] check-reqs.eclass.patch "Michał Górny" <mgorny@g.o>