1 |
Hi. |
2 |
|
3 |
Guys, please, cleanup ebuids with version bumps! |
4 |
|
5 |
Also Patrick, if you use this software or at least investigated it |
6 |
during version bump, why it is still maintainer-wanted? Although |
7 |
everything below makes me think that this was blind bump. |
8 |
|
9 |
В Пнд, 17/05/2010 в 18:41 +0000, Patrick Lauer (patrick) пишет: |
10 |
> inherit eutils flag-o-matic autotools |
11 |
> |
12 |
> TW_VER=${PV} |
13 |
|
14 |
This substitution is unnecessary and tripwire-${TW_VER} everywhere below |
15 |
is just ${P}. |
16 |
|
17 |
> DESCRIPTION="Open Source File Integrity Checker and IDS" |
18 |
> HOMEPAGE="http://www.tripwire.org/" |
19 |
> SRC_URI="mirror://sourceforge/tripwire/tripwire-${TW_VER}-src.tar.bz2 |
20 |
> mirror://gentoo/twpol.txt.gz |
21 |
> mirror://gentoo/tripwire.gif" |
22 |
> |
23 |
> LICENSE="GPL-2" |
24 |
> SLOT="0" |
25 |
> KEYWORDS="~amd64 ~ppc ~x86 ~x86-fbsd" |
26 |
> IUSE="ssl static" |
27 |
> |
28 |
> DEPEND="sys-devel/automake |
29 |
> sys-devel/autoconf |
30 |
|
31 |
This depends ^^ should be handled by autotools eclass. |
32 |
|
33 |
> dev-util/patchutils |
34 |
> ssl? ( dev-libs/openssl )" |
35 |
> RDEPEND="virtual/cron |
36 |
> virtual/mta |
37 |
> ssl? ( dev-libs/openssl )" |
38 |
> |
39 |
> S="${WORKDIR}"/tripwire-${TW_VER}-src |
40 |
> |
41 |
> src_prepare() { |
42 |
> eautoreconf || die "eautoreconf failed" |
43 |
|
44 |
|| die is not necessary here. Is autoreconf really required (nothing |
45 |
changed configure.ac/Makefile.am here). |
46 |
|
47 |
> } |
48 |
> |
49 |
> src_configure() { |
50 |
> # tripwire can be sensitive to compiler optimisation. |
51 |
> # see #32613, #45823, and others. |
52 |
> # -taviso@g.o |
53 |
|
54 |
This developer was retired 2.5 years ago. Why do we need this comment? |
55 |
|
56 |
> strip-flags |
57 |
> append-flags -DCONFIG_DIR='"\"/etc/tripwire\""' -fno-strict-aliasing |
58 |
> einfo "Done." |
59 |
|
60 |
What is "Done." here? |
61 |
|
62 |
> chmod +x configure |
63 |
> econf $(use_enable ssl openssl) $(use_enable static) |
64 |
> } |
65 |
> |
66 |
> src_install() { |
67 |
> dosbin "${S}"/bin/{siggen,tripwire,twadmin,twprint} |
68 |
|
69 |
Again || die should be here and in many other places ... |
70 |
|
71 |
> doman "${S}"/man/man{4/*.4,5/*.5,8/*.8} |
72 |
> dodir /etc/tripwire /var/lib/tripwire{,/report} |
73 |
> keepdir /var/lib/tripwire{,/report} |
74 |
> |
75 |
> exeinto /etc/cron.daily |
76 |
> doexe "${FILESDIR}"/tripwire.cron |
77 |
> |
78 |
> dodoc ChangeLog policy/policyguide.txt TRADEMARK \ |
79 |
> "${FILESDIR}"/tripwire.txt |
80 |
> |
81 |
> insinto /etc/tripwire |
82 |
> doins "${WORKDIR}"/twpol.txt "${FILESDIR}"/twcfg.txt |
83 |
> |
84 |
> exeinto /etc/tripwire |
85 |
> doexe "${FILESDIR}"/twinstall.sh |
86 |
> |
87 |
> fperms 755 /etc/tripwire/twinstall.sh /etc/cron.daily/tripwire.cron |
88 |
> } |
89 |
> |
90 |
> pkg_postinst() { |
91 |
> elog "After installing this package, you should run \"/etc/tripwire/twinstall.sh\"" |
92 |
> elog "to generate cryptographic keys, and \"tripwire --init\" to initialize the" |
93 |
> elog "database Tripwire uses." |
94 |
> elog |
95 |
> elog "A quickstart guide is included with the documentation." |
96 |
> elog |
97 |
> } |
98 |
|
99 |
|
100 |
-- |
101 |
Peter. |