From: | Hans de Graaff <graaff@g.o> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Subject: | Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig | ||
Date: | Sun, 22 May 2022 05:46:12 | ||
Message-Id: | c488c49fedd12bd91536f048aa1fc255d2f3f5b4.camel@gentoo.org | ||
In Reply to: | Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig by Thomas Bracht Laumann Jespersen |
1 | On Fri, 2022-05-20 at 09:28 +0200, Thomas Bracht Laumann Jespersen |
2 | wrote: |
3 | > > this is easy to mis in the ebuild. Handle this in the eclass |
4 | > > instead |
5 | > |
6 | > small typo: mis -> miss |
7 | |
8 | Fixed. |
9 | |
10 | > > +if [ ${#RUBY_FAKEGEM_EXTENSIONS[@]} -ge 1 ]; then |
11 | > |
12 | > shouldn't it be [[ ]] and not [ ] ? Also, just a suggestion, do "-gt |
13 | > 0" instead |
14 | > of "-ge 1" |
15 | |
16 | Yes, that probably indicates the intention a bit better (array not |
17 | empty). Changed. |
18 | |
19 | Thanks! |
20 | |
21 | Hans |
File name | MIME type |
---|---|
signature.asc | application/pgp-signature |