| 1 |
On 20.05.22 09:17, Hans de Graaff wrote: |
| 2 |
> Many C extensions depend on pkgconfig during their configure phase and |
| 3 |
> this is easy to mis in the ebuild. Handle this in the eclass instead |
| 4 |
> even though the dependency will not be needed for all extensions. |
| 5 |
> |
| 6 |
> Closes: https://bugs.gentoo.org/845393 |
| 7 |
> Signed-off-by: Hans de Graaff <graaff@g.o> |
| 8 |
> --- |
| 9 |
> eclass/ruby-fakegem.eclass | 5 +++++ |
| 10 |
> 1 file changed, 5 insertions(+) |
| 11 |
> |
| 12 |
> diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass |
| 13 |
> index 358fff1be753..754b48f82fa9 100644 |
| 14 |
> --- a/eclass/ruby-fakegem.eclass |
| 15 |
> +++ b/eclass/ruby-fakegem.eclass |
| 16 |
> @@ -210,6 +210,11 @@ case ${EAPI} in |
| 17 |
> ;; |
| 18 |
> esac |
| 19 |
> |
| 20 |
> +# Many (but not all) extensions use pkgconfig in src_configure. |
| 21 |
> +if [ ${#RUBY_FAKEGEM_EXTENSIONS[@]} -ge 1 ]; then |
| 22 |
> + BDEPEND+=" virtual/pkgconfig " |
| 23 |
> +fi |
| 24 |
> + |
| 25 |
|
| 26 |
Not sure if we have a policy on this, but how about using bash's |
| 27 |
extended test syntax, i.e., [[ … ]] (which the eclass already uses in a |
| 28 |
few places). |
| 29 |
|
| 30 |
- Flow |
Archives