Gentoo Archives: gentoo-dev

From:	Donnie Berkholz <dberkholz@g.o>
To:	gentoo-dev@l.g.o, je_fro@g.o
Subject:	[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-chemistry/gromacs: gromacs-3.3.3.ebuild gromacs-4.0.3.ebuild ChangeLog gromacs-4.0.ebuild gromacs-3.3.1-r1.ebuild gromacs-4.0.2.ebuild
Date:	Thu, 22 Jan 2009 04:54:04
Message-Id:	`20090122045359.GC9101@hermes`

1	On 04:14 Thu 22 Jan , Jeffrey Gardner (je_fro) wrote:
2	> Index: gromacs-4.0.3.ebuild
3
4	> if ( use double-precision ) ; then
5
6	What is this pointless subshell doing? There's heavy use of subshells
7	throughout this ebuild for no reason. I quoted them below when I saw
8	them.
9
10	> if ( use sse \|\| use sse2 ) ; then
11
12	> if ( ! use sse && ! use sse2 && ! use 3dnow ) ; then
13
14	> # if we need external blas
15
16	I really hope the other option is not internal blas. If so, it shouldn't
17	be an option at all. Same goes for lapack.
18
19	> if ( use double-precision && use single-precision ); then
20
21	--
22	Thanks,
23	Donnie
24
25	Donnie Berkholz
26	Developer, Gentoo Linux
27	Blog: http://dberkholz.wordpress.com