Archives
Archives
| From: | Donnie Berkholz <dberkholz@g.o> |
|---|---|
| To: | gentoo-dev@l.g.o, jokey@g.o |
| Subject: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/tcpdump: ChangeLog tcpdump-3.9.8.ebuild |
| Date: | Tue, 09 Oct 2007 19:57:57 |
| Message-Id: | 20071009194443.GD962@supernova |
| 1 | On 18:04 Tue 09 Oct , Markus Ullmann (jokey) wrote: |
| 2 | > 1.1 net-analyzer/tcpdump/tcpdump-3.9.8.ebuild |
| 3 | > |
| 4 | > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/tcpdump/tcpdump-3.9.8.ebuild?rev=1.1&view=markup |
| 5 | > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/tcpdump/tcpdump-3.9.8.ebuild?rev=1.1&content-type=text/plain |
| 6 | |
| 7 | > src_compile() { |
| 8 | > # tcpdump needs some optymalization. see bug #108391 |
| 9 | > ( ! is-flag -O? || is-flag -O0 ) && append-flags -O |
| 10 | |
| 11 | You don't need a subshell here. If you feel that it improves |
| 12 | readability, use a code block instead. |
| 13 | |
| 14 | > # Fix wrt bug #48747 |
| 15 | > if [[ $(gcc-major-version) -gt 3 ]] || \ |
| 16 | > [[ $(gcc-major-version) -eq 3 && $(gcc-minor-version) -ge 4 ]] |
| 17 | > then |
| 18 | > filter-flags -funit-at-a-time |
| 19 | > append-flags -fno-unit-at-a-time |
| 20 | > fi |
| 21 | |
| 22 | This kind of stuff might be worth verifying whether it's still needed on |
| 23 | every bump. The last comment on the bug refers to gcc 4.0.*. |
| 24 | |
| 25 | > make CCOPT="$CFLAGS" || die "make failed" |
| 26 | |
| 27 | If emake doesn't work, please add a comment to that effect. |
| 28 | |
| 29 | Thanks, |
| 30 | Donnie |
| 31 | -- |
| 32 | gentoo-dev@g.o mailing list |