Gentoo Archives: gentoo-dev

From: Sergei Trofimovich <slyfox@g.o>
To: Joshua Kinard <kumba@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: add some missing MIPS CPU errata options to ALLOWED_FLAGS
Date: Sat, 28 Mar 2020 19:43:26
Message-Id: 20200328194318.28165abd@sf
In Reply to: [gentoo-dev] [PATCH] flag-o-matic.eclass: add some missing MIPS CPU errata options to ALLOWED_FLAGS by Joshua Kinard
1 On Sat, 28 Mar 2020 15:17:12 -0400
2 Joshua Kinard <kumba@g.o> wrote:
3
4 > Noticed during a glibc build for MIPS-III ISA that the -mfix-r4000
5 > and -mfix-r4400 gcc flags got stripped off. These are needed to work
6 > around known CPU errata in R4000 and R4400 CPUs. In addition, also
7 > add the -mfix-rm7000 option (and it's -mno form) to fix errata in the
8 > PMC RM7000 CPU, and the -mr10k-cache-barrier to control the generation
9 > of cache barriers to work around the side-effects of R10000's
10 > speculative execution capabilities.
11 >
12 > Signed-off-by: Joshua Kinard <kumba@g.o>
13 > ---
14 > eclass/flag-o-matic.eclass | 4 +++-
15 > 1 file changed, 3 insertions(+), 1 deletion(-)
16 >
17 > diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
18 > index e76eef293e..0c67ec9f7a 100644
19 > --- a/eclass/flag-o-matic.eclass
20 > +++ b/eclass/flag-o-matic.eclass
21 > @@ -56,7 +56,9 @@ setup-allowed-flags() {
22 > -mno-faster-structs -mfaster-structs -m32 -m64 -mx32 -mabi
23 > -mlittle-endian -mbig-endian -EL -EB -fPIC -mlive-g0 -mcmodel
24 > -mstack-bias -mno-stack-bias -msecure-plt '-m*-toc' -mfloat-abi
25 > - -mfix-r10000 -mno-fix-r10000 -mthumb -marm
26 > + -mfix-r4000 -mno-fix-r4000 -mfix-r4400 -mno-fix-r4400
27 > + -mfix-rm7000 -mno-fix-rm7000 -mfix-r10000 -mno-fix-r10000
28 > + -mr10k-cache-barrier -mthumb -marm
29 >
30 > # gcc 4.5
31 > -mno-fma4 -mno-movbe -mno-xop -mno-lwp
32
33 Looks good!
34
35 --
36
37 Sergei