[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: media-sound/musique/files/, media-sound/musique/

[hasufell]

On 10/09/2015 04:42 PM, Michael Palimaka wrote:
> commit:     2f9b36011ada0104883275fad335084922f5c9c6
> Author:     Michael Palimaka <kensington <AT> gentoo <DOT> org>
> AuthorDate: Fri Oct  9 14:40:56 2015 +0000
> Commit:     Michael Palimaka <kensington <AT> gentoo <DOT> org>
> CommitDate: Fri Oct  9 14:42:22 2015 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f9b3601
>
> media-sound/musique: version bump
>

reformatted, because email reviews are broken

diff --git a/media-sound/musique/musique-1.4.ebuild
b/media-sound/musique/musique-1.4.ebuild
new file mode 100644
index 0000000..6e40cbb
--- /dev/null
+++ b/media-sound/musique/musique-1.4.ebuild
@@ -0,0 +1,46 @@
+# Copyright 1999-2015 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+# $Id$
+
+EAPI="5"
+
+inherit eutils qt4-r2
+
+DESCRIPTION="Qt4 music player"
+HOMEPAGE="http://flavio.tordini.org/musique"
+SRC_URI="http://flavio.tordini.org/files/${PN}/${P}.tar.gz"
+
+LICENSE="GPL-3"

It seems this can be GPL-3+, see
https://github.com/flaviotordini/musique#legal-stuff

+SLOT="0"
+KEYWORDS="~amd64 ~x86"
+IUSE=""
+
+RDEPEND="
+	dev-qt/qtcore:4
+	dev-qt/qtdbus:4
+	dev-qt/qtgui:4
+	dev-qt/qtsingleapplication[qt4,X]
+	dev-qt/qtsql:4[sqlite]
+	|| ( dev-qt/qtphonon:4 media-libs/phonon[qt4] )
+	media-libs/taglib
+"
+DEPEND="${RDEPEND}"
+
+S="${WORKDIR}/${PN}"
+
+DOCS=( CHANGES TODO )
+
+src_prepare () {
+	epatch "${FILESDIR}"/${P}-unbundle-qtsingleapplication.patch
+	rm -r src/qtsingleapplication || die
+	qt4-r2_src_prepare
+}
+
+src_configure() {
+	eqmake4 ${PN}.pro PREFIX="/usr"
+}
+
+src_install() {
+	qt4-r2_src_install
+	doicon data/${PN}.svg

is this icon referenced in a hardcoded way? Otherwise, you can do:
doicon -s scalable data/${PN}.svg

which will install it into /usr/share/icons/hicolor/scalable/apps
which is the more modern location.

doicon also allows -c and -t switches, see
https://devmanual.gentoo.org/eclass-reference/eutils.eclass/index.html

If you go for that location, you also need to update icon cache for
users who run qt applications inside a gtk based DE via gnome2-utils.eclass.

Maybe these cache updates should be replaced by PM hooks, but I'm not
sure if portage hooks support is good enough for that.