1 |
On Mon, 2021-01-18 at 23:47 +0100, Jonas Stein wrote: |
2 |
> Hi, |
3 |
> |
4 |
> it would be nice to have parser friendly comments in package.mask |
5 |
> |
6 |
> The new format |
7 |
> - must be as easy to read and write for humans as it is now. |
8 |
> - must be structured |
9 |
> |
10 |
> |
11 |
> |
12 |
> Benefits of a parser friendly package.mask: |
13 |
> |
14 |
> - use it for statistics |
15 |
> - list all packages which are overdue |
16 |
> - pretty print a sorted list |
17 |
> - use syntax highlighting and folding in editors |
18 |
> - better pkgcheck/repoman checks for malformed masks |
19 |
> - automatic nice and readable commit messages |
20 |
> - get even more out of the mgorny-dev-scripts |
21 |
> https://github.com/mgorny/mgorny-dev-scripts/blob/master/lr-add-pmask |
22 |
> - all items have the same structure |
23 |
> - # Removal after: 2021-09-01 is easier to read than |
24 |
> # Masked for removal in 90 days. |
25 |
> |
26 |
> |
27 |
> Example workflow on the command line |
28 |
> |
29 |
> $> lr-add-pmask app-misc/some-package 987654 2019-07-01 "Doesn't work |
30 |
> with new libfoo. Upstream dead, gtk-1, smells all commented lines after |
31 |
> Reason are the reason." |
32 |
> |
33 |
> $> lr-commit-pmask |
34 |
> |
35 |
> |
36 |
> |
37 |
> |
38 |
> OLD FORMAT |
39 |
> |
40 |
> # Dev E. Loper <developer@g.o> (2019-07-01) |
41 |
> # Masked for removal in 90 days. Doesn't work |
42 |
> # with new libfoo. Upstream dead, gtk-1, smells |
43 |
> # funny. (bug #987654). Others write Bug 123456. |
44 |
> # Bug 1 is known well, but the second bug 2 hours to fix. |
45 |
> app-misc/some-package |
46 |
> |
47 |
> |
48 |
> Add your suggestions below for discussion: |
49 |
> |
50 |
> |
51 |
> Suggestion 1) |
52 |
> |
53 |
> # Masked on: 2019-07-01 |
54 |
> # Masked by: Dev E. Loper <developer@g.o> |
55 |
> # Removal after: 2019-09-01 |
56 |
> # Bugs: 123456, 123457 |
57 |
> # Reason: Doesn't work with new libfoo. Upstream dead, gtk-1, smells |
58 |
> # all commented lines after Reason are the reason. |
59 |
> app-misc/some-package |
60 |
> |
61 |
> |
62 |
> Suggestion 2) |
63 |
> # MASKED ON: 2019-07-01 |
64 |
> # MASKED BY: Dev E. Loper <developer@g.o> |
65 |
> # REMOVAL AFTER: 2019-09-01 |
66 |
> # BUGS: 123456 123457 |
67 |
> # REASON: Doesn't work with new libfoo. Upstream dead, gtk-1, smells |
68 |
> # all commented lines after Reason are the reason. Uppercase to |
69 |
> # emphasize keywords. |
70 |
> app-misc/some-package |
71 |
> |
72 |
> |
73 |
> |
74 |
> Suggestion 3) |
75 |
> write your suggestion HERE |
76 |
> |
77 |
> How can we improve the format of package.mask for future scripts? |
78 |
> Which suggestion is your preference? |
79 |
|
80 |
I don't like the idea of splitting bugnos and reason. It generally |
81 |
makes sense to link a specific part reason to a specific bug. |
82 |
|
83 |
The first line is well-defined by now and I don't think it needs |
84 |
changing, and the new format looks much longer than necessary. |
85 |
|
86 |
I think just putting the removal date in plain |
87 |
'removal (after|on) YYYY-MM-DD' format would be improvement enough. |
88 |
Bugnos are rather easy to grep. |
89 |
|
90 |
-- |
91 |
Best regards, |
92 |
Michał Górny |