Gentoo Archives: gentoo-dev

From: Dan Douglas <ormaaj@×××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays
Date: Thu, 23 Jun 2016 00:35:44
Message-Id: 3dd77a2f-1967-a7b3-7702-6507953ab44b@gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays by Ulrich Mueller
1 On 06/22/2016 07:12 PM, Ulrich Mueller wrote:
2 >>>>>> On Wed, 22 Jun 2016, Dan Douglas wrote:
3 >
4 >> + [[
5 >> + ( BASH_VERSINFO[0] -ge 4 || EAPI -ge 6 ) &&
6 >> + $(declare -p "EGIT_${livevars[idx+1]}" 2>/dev/null) == 'declare -A'*
7 >> + ]] && ref=EGIT_${livevars[idx+1]}[\$PN]
8 >
9 > EAPI is not a number but a string, so don't use arithmetic comparison
10 > to test for it
11
12 You mean in the future it may have non-digit values that pass the
13 `case $EAPI in ...)` at the top? I debated whether to include that at
14 all since I thought the intention was for these variables to never be
15 used in an ebuild/eclass, so we're just using the array
16 opportunistically - basically.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies