| 1 |
On 18-08-2011 21:41:47 +0200, Michał Górny wrote: |
| 2 |
> On Thu, 18 Aug 2011 20:43:59 +0200 |
| 3 |
> Fabian Groffen <grobian@g.o> wrote: |
| 4 |
> |
| 5 |
> > On 18-08-2011 20:42:23 +0200, Michał Górny wrote: |
| 6 |
> > > > elif [[ ${PN} != "leechcraft-core" ]]; then |
| 7 |
> > > > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-} |
| 8 |
> > > |
| 9 |
> > > Don't quote that. It looks bad that the left-side is unquoted and |
| 10 |
> > > right side is quoted. |
| 11 |
> > |
| 12 |
> > it's a string, what's the problem? |
| 13 |
> |
| 14 |
> It's just a matter of taste. I think it looks better if both sides are |
| 15 |
> quoted, or neither is. |
| 16 |
|
| 17 |
Right, it's a matter of taste, so the snippet is fine as-is. |
| 18 |
|
| 19 |
Commenting on code is fine, Just don't present your taste as if it is |
| 20 |
the only right thing to do. |
| 21 |
|
| 22 |
|
| 23 |
-- |
| 24 |
Fabian Groffen |
| 25 |
Gentoo on a different level |
Archives