Re: [gentoo-dev] [PATCH v2] xdg.eclass: add EAPI 8 support

[Ulrich Mueller]

>>>>> On Wed, 21 Jul 2021, Florian Schmaus wrote:
 
>  case "${EAPI:-0}" in

This could be simplified to ${EAPI} (and no quotation marks).

>  	4|5|6|7)
> -		EXPORT_FUNCTIONS src_prepare pkg_preinst pkg_postinst pkg_postrm
> +		# src_prepare is only exported in EAPI < 8.
> +		EXPORT_FUNCTIONS src_prepare
> +		;&

The ;& terminator is a new Bash feature and cannot be used in EAPIs
older than 6. (Easy to fix: Simply move the following EXPORT_FUNCTIONS
below the case block.)

> +	8)
> +		EXPORT_FUNCTIONS pkg_preinst pkg_postinst pkg_postrm
>  		;;
>  	*) die "EAPI=${EAPI} is not supported" ;;

Please prepend "${ECLASS}: " to the die message.

>  esac
 
>  # @FUNCTION: xdg_src_prepare
>  # @DESCRIPTION:
>  # Prepare sources to work with XDG standards.
> +# Note that this function is only exported in EAPIs < 8.
>  xdg_src_prepare() {
>  	xdg_environment_reset

I wonder, should the function be defined in EAPI 8 then? It calls
default, so presumably ebuilds would rather call xdg_environment_reset
directly?

Ulrich