Archives
Archives
| From: | Donnie Berkholz <dberkholz@g.o> |
|---|---|
| To: | gentoo-dev@l.g.o, arfrever@g.o |
| Subject: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: subversion.eclass |
| Date: | Mon, 11 May 2009 05:43:23 |
| Message-Id: | 20090511054318.GD7834@comet |
| 1 | On 20:33 Sun 10 May , Arfrever Frehtes Taifersar Arahesis (arfrever) wrote: |
| 2 | > arfrever 09/05/10 20:33:38 |
| 3 | > |
| 4 | > Modified: subversion.eclass |
| 5 | > Log: |
| 6 | > Add possibility of not including Subversion in DEPEND. |
| 7 | > Run 'svn upgrade' to automatically upgrade working copies. |
| 8 | |
| 9 | A good entry also explains the *reason* for doing something. Anyone |
| 10 | could read the code and see what changed, but the person making the |
| 11 | change is the only person who knows exactly why. |
| 12 | |
| 13 | > Revision Changes Path |
| 14 | > 1.67 eclass/subversion.eclass |
| 15 | > |
| 16 | > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/subversion.eclass?rev=1.67&view=markup |
| 17 | > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/subversion.eclass?rev=1.67&content-type=text/plain |
| 18 | > diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/subversion.eclass?r1=1.66&r2=1.67 |
| 19 | |
| 20 | > -EXPORTED_FUNCTIONS="src_unpack pkg_preinst" |
| 21 | > case "${EAPI:-0}" in |
| 22 | > - 2) EXPORTED_FUNCTIONS="${EXPORTED_FUNCTIONS} src_prepare" ;; |
| 23 | > - 1|0) ;; |
| 24 | > - *) die "Unknown EAPI, Bug eclass maintainers." ;; |
| 25 | > + 0|1) |
| 26 | > + EXPORT_FUNCTIONS src_unpack pkg_preinst |
| 27 | > + ;; |
| 28 | > + *) |
| 29 | > + EXPORT_FUNCTIONS src_unpack src_prepare pkg_preinst |
| 30 | > + ;; |
| 31 | > esac |
| 32 | |
| 33 | Might this have been worth mentioning in the commit entry? |
| 34 | |
| 35 | -- |
| 36 | Thanks, |
| 37 | Donnie |
| 38 | |
| 39 | Donnie Berkholz |
| 40 | Developer, Gentoo Linux |
| 41 | Blog: http://dberkholz.wordpress.com |