Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Andreas Sturmlechner <asturm@g.o>
Cc: gentoo-dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in <EAPI-8, fix eclassdoc, make some funcs internal
Date: Wed, 31 Mar 2021 09:10:00
Message-Id: u5z173d0m@gentoo.org
In Reply to: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in by Andreas Sturmlechner
1 >>>>> On Wed, 31 Mar 2021, Andreas Sturmlechner wrote:
2
3 > setup-allowed-flags() {
4 > + [[ ${EAPI} == [0-7] ]] ||
5 > + die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
6 > + _setup-allowed-flags
7 > +}
8
9 Strictly speaking, EAPIs are strings, so numeric comparison is not
10 meaningful. Suggestion: "... is not available in EAPI ${EAPI}."
11
12 > test-flag-PROG() {
13 > + [[ ${EAPI} == [0-7] ]] ||
14 > + die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
15 > + _test-flag-PROG
16 > +}
17
18 > test-flags-PROG() {
19 > + [[ ${EAPI} == [0-7] ]] ||
20 > + die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
21 > + _test-flags-PROG
22 > +}
23
24 Same for these.
25
26 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies