Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Florian Schmaus <flow@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [PATCH 1/1] edo.eclass: add new eclass
Date: Sat, 16 Apr 2022 11:55:52
Message-Id: u8rs5tf80@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [PATCH 1/1] edo.eclass: add new eclass by Florian Schmaus
1 >>>>> On Sat, 16 Apr 2022, Florian Schmaus wrote:
2
3 >> edobe() {
4
5 > nit: I'd personally would use 'edob', as shorter is sometimes better
6 > plus every begin needs an end, so no need to explicitly state that
7 > there is an end.
8
9 It's even more obscure as a name however. :)
10
11 >> ebegin "Running $@"
12 >> "$@"
13 >> eend $? || die -n "$@ failed"
14 >> return $?
15
16 > I think this return statement can be omitted since it will always be
17 > invoked with 0 as argument, and this is the default behavior of
18 > implicit function return (IIRC).
19
20 You're right, the return statement is redundant.
21
22 >> }
23
24 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature