Re: [gentoo-dev] xcircuit

[Tod M. Neidt]

On Fri, 2002-04-05 at 05:35, Carl-Christian Salvesen wrote:
> On Fri, 2002-04-05 at 11:27, michael wrote:
> > could someone make an ebuild for the latest version of xcircuit?
> > :)
>
> Looks like gentoo.org is down. Can you confirm that my ebuild works?
> http://struct.homeip.net/gentoo/beta/
>
> Just unpack it in /usr/portage and emerge xcircuit..
Hi!

Already made one for xcircuit-2.5.4 (the website implies this one is
prefereable).  I added it to app-misc ( arguable where it should go).
Although an official stable one might be nice too :)

What follows is offered as constructive criticism.  If you clean up your
ebuild in light of the following comments, I would be more than happy to
commit it for you.

1. Remove all the unnecessary comments leftover from the skel.ebuild.

2. This application has dependencies. Add them to DEPENDS, not everyone
who will emerge this will already have all the dependencies merged. Read
the docs, website, and/or 'ldd xcircuit' to figure out the dependencies.

3. Although it doesn't hurt anything, this app has no info file so the
--info= line in the configure can be removed.

4. xcircuit-2.5.4 had a non-fatal compile error related to parameter.c
looking for menudep.h with a parallel compile (emake) and needed to be
compiled with a ordinary make to avoid this.  Did you confirm that
xcircuit-2.3.3 compiled without error? Although the app runs, I imagine
that the functionality is impaired.

Your contributions to Gentoo Linux are appreciated.  Tidy up your
xcircuit-2.3.3.ebuild and mail it as an attachement to tod@g.o
and we'll get it committed into the portage tree.

Thanks!

tod

P.S. You can also refer to app-misc/xcircuit/xcircuit-2.5.4.ebuild