Gentoo Archives: gentoo-dev

From: Matthias Schwarzott <zzam@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild
Date: Tue, 25 Sep 2007 09:06:18
Message-Id: 200709251054.43817.zzam@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild by Donnie Berkholz
1 On Montag, 24. September 2007, Donnie Berkholz wrote:
2 > On 19:59 Mon 24 Sep , Matthias Schwarzott (zzam) wrote:
3 > > zzam 07/09/24 19:59:38
4 > >
5 >
6 > This ebuild has really inconsistent use of tests, quotes in tests, and
7 > command substitutions. Being more consistent will increase readability
8 > and decrease bugs due to differences between styles. For tests, pick a
9 > style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice
10 > because it generally doesn't require quotes, so the code looks a lot
11 > cleaner. For command substitions, prefer $() over ``.
12 >
13 > > newins ${FILESDIR}/blacklist-110 blacklist
14 > > doins ${FILESDIR}/pnp-aliases
15 >
16 > Quotes here.
17 >
18 > > emake \
19 > > EXTRAS="${extras}" \
20 > > libudevdir=${udev_helper_dir} \
21 > > CROSS_COMPILE=${mycross} \
22 > > OPTFLAGS="" \
23 > > ${myconf} || die
24 > >
25 > > emake \
26 > > DESTDIR="${D}" \
27 > > libudevdir=${udev_helper_dir} \
28 > > EXTRAS="${extras}" \
29 > > ${myconf} \
30 > > install || die
31 >
32 > Could use some die messages here.
33 >
34 > Thanks,
35 > Donnie
36
37 fixed, thanks
38
39 Matthias
40
41 --
42 Matthias Schwarzott (zzam)
43 --
44 gentoo-dev@g.o mailing list