Gentoo Archives: gentoo-dev

From: "Robin H. Johnson" <robbat2@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2 4/4] dev-vcs/cli: new package
Date: Wed, 19 Feb 2020 07:44:01
Message-Id: robbat2-20200219T073909-378848713Z@orbis-terrarum.net
In Reply to: Re: [gentoo-dev] [PATCH v2 4/4] dev-vcs/cli: new package by William Hubbs
1 On Wed, Feb 19, 2020 at 12:18:24AM -0600, William Hubbs wrote:
2 > > +RDEPEND+=">=dev-vcs/git-1.7.3"
3 > > +BDEPEND+=">=dev-lang/go-1.13"
4 > > +GOPATH="${WORKDIR}"
5 > You don't need += here
6 I've taken to += as a cleaner variant than xDEPEND="${xDEPEND} cat/pn"
7 when the eclass MAY be setting some dependencies already.
8
9 > or any value of GOPATH.
10 GOPATH is required in fact!
11
12 Without it being set, it inherits GOPATH from my scope when I run emerge
13 or ebuild, and since the portage user doesn't have permission to write
14 in that path, the Golang mod tooling fails during src_unpack for the
15 tidy/get calls. If those are skipped, then it fails during the build.
16 The vendor mode didn't have this issue, because it handles differently.
17
18 I do note that this is despite what the Golang docs say about
19 GO111MODULE envvar being set should cause GOPATH to be ignored.
20
21 The other two packages, go-tour and kube-bench explicitly set GOPATH in
22 their builds, so didn't run into this.
23
24 --
25 Robin Hugh Johnson
26 Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
27 E-Mail : robbat2@g.o
28 GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
29 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

Attachments

File name MIME type
signature.asc application/pgp-signature