| 1 |
On Sun, Dec 4, 2016 at 6:18 PM, Andreas K. Huettel <dilfridge@g.o> wrote: |
| 2 |
> |
| 3 |
> Please review. Given that I'm only tangentially involved with Apache myself, I |
| 4 |
> would like to keep the changes to the eclass minimal... |
| 5 |
> |
| 6 |
> [The last nontrivial changes to the eclass were made in 2012 and 2008.] |
| 7 |
|
| 8 |
For future patches, please use git send-email if possible. Makes it |
| 9 |
easier to review in an email client. |
| 10 |
|
| 11 |
> + declare -f -F get_libdir > /dev/null || |
| 12 |
|
| 13 |
Nit: the -F option implies -f; passing both is unnecessary. |
| 14 |
|
| 15 |
Otherwise, the changes seem fine. |
Archives