Gentoo Archives: gentoo-dev

From: Greg Turner <gmt@×××××.us>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o, Greg Turner <gmt@×××××.us>
Subject: Re: [gentoo-dev] some multilib-minimal enhancements [4/6]: ubiquitous multilib-<phase>-all callbacks
Date: Wed, 11 Dec 2013 23:47:44
Message-Id: CA+VB3NTvvG7xyukkewuOS=SwDzJjSGj1SLXDX6rXTyOKf3H-cA@mail.gmail.com
In Reply to: Re: [gentoo-dev] some multilib-minimal enhancements [4/6]: ubiquitous multilib--all callbacks by "Michał Górny"
1 On Wed, Dec 11, 2013 at 2:40 PM, Michał Górny <mgorny@g.o> wrote:
2 >> This patch adds multilib_src_{configure,compile,test}_all
3 >> callbacks, analogous to the existing multilib_src_install_all
4 >> callback.
5 >
6 > No real benefit in having those.
7
8 There is no fundamental semantic benefit I can think of; indeed, as
9 pointed out above, the "portage-standard"
10 phase-function-implementation-override +
11 direct-invocation-of-overridden-phase-function recipe has slightly
12 greater semantic power. However, subjectively speaking, I feel that
13 using the multilib_<phase>_all callbacks make for cleaner and easier
14 to follow code. My thinking was that providing two ways to achieve
15 the same thing should be harmless -- ebuild authors are, after all,
16 coding bash scripts to run in a UNIX-like environment, so hopefully
17 they are comfortable choosing between multiple-ways-to-do-it :)
18
19 However, I'm not so attached to this patch that I'd put up a big fight
20 over it; my overlay doesn't use them, and they are, strictly-speaking,
21 superfluous.
22
23 -gmt