Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Sam James <sam@g.o>
Cc: gentoo-dev@l.g.o, kernel@g.o
Subject: Re: [gentoo-dev] [PATCH 3/3] kernel-2.eclass: minor whitespace fixes
Date: Sun, 25 Dec 2022 22:15:05
Message-Id: uh6xjjfl2@gentoo.org
In Reply to: [gentoo-dev] [PATCH 3/3] kernel-2.eclass: minor whitespace fixes by Sam James
1 >>>>> On Sun, 25 Dec 2022, Sam James wrote:
2
3 > - [[ $# -gt 3 ]] && die "Error in kernel-2_kernel_is(): too many parameters"
4 > + [[ $# -gt 3 ]] && die "Error in ${ECLASS}_${FUNCNAME}(): too many parameters"
5
6 This might be somewhat misleading. The name of the function is just
7 ${FUNCNAME}, I suppose? (Also, "Error in" is redundant in a die
8 message.)

Attachments

File name MIME type
signature.asc application/pgp-signature