Gentoo Archives: gentoo-dev

From: "Anthony G. Basile" <blueness@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: [gentoo-dev] RFC: pax-utils.eclass, downgrade from elog to einfo to avoid flooding logs
Date: Tue, 03 Apr 2012 13:57:22
Message-Id: 4F7B0166.8020003@gentoo.org
1 Hi everyone,
2
3 pax-utils.eclass generates a lot of log messages when marking a large
4 number of files, for example icedtea-bin. These messages are not that
5 useful, so I propose downgrading all elog's to einfo's to avoid
6 flooding. See bug #407503. If there are no objections, I'll commit the
7 following in a few days:
8
9 --- pax-utils.eclass.orig 2012-04-03 09:29:41.000000000 -0400
10 +++ pax-utils.eclass 2012-04-03 09:30:49.000000000 -0400
11 @@ -58,8 +58,8 @@
12 # Try paxctl, then scanelf. paxctl is preferred.
13 if type -p paxctl> /dev/null&& has PT ${PAX_MARKINGS}; then
14 # Try paxctl, the upstream supported tool.
15 - elog "PT PaX marking -${flags}"
16 - _pax_list_files elog "$@"
17 + einfo "PT PaX marking -${flags}"
18 + _pax_list_files einfo "$@"
19 for f in "$@"; do
20 # First, try modifying the existing PAX_FLAGS header
21 paxctl -q${flags} "${f}"&& continue
22 @@ -91,8 +91,8 @@
23 elif type -p scanelf> /dev/null&& [[ ${PAX_MARKINGS} != "none" ]]; then
24 # Try scanelf, the Gentoo swiss-army knife ELF utility
25 # Currently this sets PT if it can, no option to control what it does.
26 - elog "Fallback PaX marking -${flags}"
27 - _pax_list_files elog "$@"
28 + einfo "Fallback PaX marking -${flags}"
29 + _pax_list_files einfo "$@"
30 scanelf -Xxz ${flags} "$@"
31 elif [[ ${PAX_MARKINGS} != "none" ]]; then
32 # Out of options!
33
34
35
36 --
37 Anthony G. Basile, Ph.D.
38 Gentoo Linux Developer [Hardened]
39 E-Mail : blueness@g.o
40 GnuPG FP : 8040 5A4D 8709 21B1 1A88 33CE 979C AF40 D045 5535
41 GnuPG ID : D0455535

Replies