Re: [gentoo-dev] RFC: fox.eclass update

[Peter Volkov]

В Чтв, 16/09/2010 в 16:24 +0200, Matti Bickel пишет:
> +FOXVER=`get_version_component_range 1-2 ${FOX_PV}`

It's better to prefer $() style over ``:
http://mywiki.wooledge.org/BashFAQ/082

>  if [ "${PN}" != fox ] ; then
>         FOX_COMPONENT="${FOX_COMPONENT:-${PN}}"
>  fi
>
> -if [ "${FOXVER}" != "1.0" ] && [ -z "${FOX_COMPONENT}" ] ; then
> +if [ -z "${FOX_COMPONENT}" ] ; then
>         DOXYGEN_DEP="doc? ( app-doc/doxygen )"
>  fi

It's better to use [[ ]] and avoid quotes since ebuilds are bash
scripts.

> -       elibtoolize
> +       eautoreconf

Hm, is this change necessary?

> +       if ( ! use doc ) && [ -d "${D}/usr/share/doc/${PF}/html" ] ;
> then

Subshell looks redundant here.

> +               epause

It's better to avoid epause as it makes build slower at the same time
it's most probable that nobody is looking on the screen at the moment[1]
and portage will print all elog messages at the end of the build in any
case.
 
[1] while emerge output is one of those things one can observe for ages
(like water, fire and others working) still it's possible no one
thoughtfully staring at the screen...

-- 
Peter.