| 1 |
On 13:21 Mon 30 May , Ulrich Mueller wrote: |
| 2 |
> >>>>> On Mon, 30 May 2011, Diego Elio Pettenò wrote: |
| 3 |
> > Il giorno lun, 30/05/2011 alle 08.27 +0200, Michał Górny ha scritto: |
| 4 |
> >> S="${WORKDIR}/solutious-${PN}-*" |
| 5 |
> >> |
| 6 |
> >> I'm surprised if that actually works. I'd say that seems not |
| 7 |
> >> PMS-compliant but in fact PMS seems to almost not mention S. |
| 8 |
> |
| 9 |
> > Because you didn't follow the whole eclass tree ;) |
| 10 |
> |
| 11 |
> > ruby-ng handles the star as a special case, given how many of those |
| 12 |
> > we had to use over time, [...] |
| 13 |
> |
| 14 |
> But it is not compliant with PMS: |
| 15 |
> "If S is assigned in the global scope of an ebuild, then the |
| 16 |
> restrictions of section 12.2 for global variables apply." (section 12.1) |
| 17 |
> "Global variables must only contain invariant values." (section 12.2) |
| 18 |
|
| 19 |
It seems compliant to me, as S is assigned an invariant value that |
| 20 |
happens to contain the character '*', which is overwritten with a new |
| 21 |
value as a local variable in ebuild functions. Sample code in listing |
| 22 |
12.1 in my copy of the PMS seems to suggest this is perfectly fine |
| 23 |
behavior as long as the global invariant is restored after each |
| 24 |
function. |
| 25 |
|
| 26 |
-- |
| 27 |
Thanks, |
| 28 |
Donnie |
| 29 |
|
| 30 |
Donnie Berkholz |
| 31 |
Sr. Developer, Gentoo Linux |
| 32 |
Blog: http://dberkholz.com |
Archives