| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 02/24/2013 07:56 PM, Michał Górny wrote: |
| 5 |
>> It's that "Plus" part that is my problem with |
| 6 |
>> autotools-multilib.eclass currently, it adds EXPORT_FUNCTIONS of |
| 7 |
>> src_prepare() from autotools-utils.eclass which is irrelevant to |
| 8 |
>> the autotools-multilib.eclass adds just another eclass/phase |
| 9 |
>> function to worry about for inherit order |
| 10 |
> |
| 11 |
> I understand your concern but I see no way around it. The |
| 12 |
> alternative solution exports src_prepare() as well to copy the |
| 13 |
> sources -- so it's even more to worry about than the |
| 14 |
> no-op-by-default. |
| 15 |
|
| 16 |
No, I don't export src_prepare. The developer has to call |
| 17 |
"prepabisources" at the end of src_prepare himself, but only if he |
| 18 |
wants to use IN_SOURCE_BUILD (this seems to be a requirement for |
| 19 |
waf-utils ebuilds at first glance). |
| 20 |
|
| 21 |
It's a bit similar to prepgamesdirs. I find it easier to require |
| 22 |
calling it explicitly since src_prepare is often times a very custom |
| 23 |
function. |
| 24 |
-----BEGIN PGP SIGNATURE----- |
| 25 |
Version: GnuPG v2.0.19 (GNU/Linux) |
| 26 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 27 |
|
| 28 |
iQEcBAEBAgAGBQJRKmyaAAoJEFpvPKfnPDWzQNsH/iMfm5+k2CuFwX1MEIf28DAp |
| 29 |
4onvA2zEKCZCDMU4+eTLr3he04Qhy1NJb2WIqK4ZsRMHZvrtLoDR1PlLSgBN1Zs7 |
| 30 |
pYOTtOama9M6ha50jZmDptsG6GlZEWkuDvhYloHa1nKmCUaQdUJ6Cks53vkT1WmX |
| 31 |
+Xaz/NJUCKARWj4yU6UzYxyh+kklLm/rSZPSDlpu329XD9aPUlRfH+QBQMY5S6gy |
| 32 |
88VfbG0al+k0S7aB6Xj8gjCktj3ZLY0b4vMx6d0mrVw6sY1lJnz73Bd4NVCpW2QH |
| 33 |
UlLDMthlVLOhRDIxaLcJcSOkEJ4/LDANSR45zQviurqUKjQy68Ve3DztlFaVEXo= |
| 34 |
=lp6W |
| 35 |
-----END PGP SIGNATURE----- |
Archives