Re: [gentoo-dev] [PATCH] git-r3.eclass: respect EVCS_UMASK

[Michał Górny]

Dnia 2015-02-02, o godz. 10:46:34
Ulrich Mueller <ulm@g.o> napisał(a):

> >>>>> On Sun, 1 Feb 2015, I wrote:
>
> >>>>> On Sun, 1 Feb 2015, Michał Górny wrote:
>
> >>> +		local restore_umask=":"
> >>> +		if [[ ${EVCS_UMASK} ]]; then
> >>> +			restore_umask=$(umask -p)
> >>> +			umask "${EVCS_UMASK}" || die "Bad options to umask: ${EVCS_UMASK}"
> >>> +		fi
> >>> mkdir "${GIT_DIR}" || die
> >>> git init --bare || die
> >>> +		${restore_umask} || die
>
> >> And this has ugly implicit pattern expansion. Don't do such things.
> >> Ever. Even if you want to split commands.
>
> > Please show me how this could possibly cause any problem here.
> > restore_umask can only have well-defined values, either ":" or
> > the output of "umask -p" which is intended to be used this way.
>
> Anyway, since you don't seem to like the way it is coded, I've
> attached an updated patch.

Yes, I like the old fashion way a lot more ;). Thanks.

-- 
Best regards,
Michał Górny