Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Dan Douglas <ormaaj@×××××.com>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays
Date: Thu, 23 Jun 2016 18:48:58
Message-Id: 20160623204841.026ef33f.mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays by Dan Douglas
1 On Wed, 22 Jun 2016 18:22:38 -0500
2 Dan Douglas <ormaaj@×××××.com> wrote:
3
4 > This creates new associative arrays for each "live" variable if bash4 /
5 > eapi6 is available. Mainly for user convenience in a bashrc as an
6 > alternative to magic variable names.
7 > ---
8 > eclass/git-r3.eclass | 68 ++++++++++++++++++++++++++++++----------------------
9 > 1 file changed, 39 insertions(+), 29 deletions(-)
10
11 My first thought was: no, thanks, no more complexity. But after some
12 thinking, I guess this may actually be better. It would be best if we
13 could kill the old way but I doubt it's a good idea right now.
14
15 Before giving you the final answer/review, I'm going to wait a while to
16 see what others think. In the meantime, you could also think if this
17 could be extended to support overrides on direct git-r3_fetch calls,
18 i.e. when ebuild fetches multiple repos.
19
20 My first thought would be to use original repo URI as the key instead
21 of PN. Or maybe support both, i.e. PN for global override and URI for
22 in-fetch override.
23
24 One request though: don't use PN but CATEGORY/PN.
25
26 --
27 Best regards,
28 Michał Górny
29 <http://dev.gentoo.org/~mgorny/>

Replies

Subject Author
Re: [gentoo-dev] [PATCH] git-r3.eclass: Make EGIT_LIVE_* associative arrays Dan Douglas <ormaaj@×××××.com>