Archives
Archives
| From: | Sergei Trofimovich <slyfox@g.o> | ||
|---|---|---|---|
| To: | Mike Gilbert <floppym@g.o> | ||
| Cc: | Gentoo Dev <gentoo-dev@l.g.o> | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/2] toolchain-funcs.eclass: export tc-get*READELF helpers, bug #725304 | ||
| Date: | Mon, 25 May 2020 20:49:00 | ||
| Message-Id: | 20200525214851.2510f2e5@sf | ||
| In Reply to: | Re: [gentoo-dev] [PATCH 1/2] toolchain-funcs.eclass: export tc-get*READELF helpers, bug #725304 by Mike Gilbert |
||
| 1 | On Mon, 25 May 2020 11:30:29 -0400 |
| 2 | Mike Gilbert <floppym@g.o> wrote: |
| 3 | |
| 4 | > On Mon, May 25, 2020 at 9:06 AM Sergei Trofimovich <slyfox@g.o> wrote: |
| 5 | > > |
| 6 | > > Bug: https://bugs.gentoo.org/725304 |
| 7 | > > Signed-off-by: Sergei Trofimovich <slyfox@g.o> |
| 8 | > |
| 9 | > Both patches look good to me. |
| 10 | > |
| 11 | > However, I think you should remove the bug number from the summary |
| 12 | > line; it makes the summary too long and the Bug tag later in the |
| 13 | > commit message is sufficient. |
| 14 | |
| 15 | Sounds good! Dropped bug number and pushed as: |
| 16 | https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ccdea417c4a259a03a745e3a977ac56827be5ae4 |
| 17 | https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bd13f6d55a51f2a1f4da69a41df7973fa7503cc |
| 18 | |
| 19 | -- |
| 20 | |
| 21 | Sergei |