Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
Date: Fri, 13 Dec 2019 11:50:29
Message-Id: 9079ccd7b470c5466b0a18476b2c4d561b15fe2f.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default by Mike Gilbert
1 On Thu, 2019-12-12 at 12:14 -0500, Mike Gilbert wrote:
2 > On Thu, Dec 12, 2019 at 12:02 PM NP-Hardass <NP-Hardass@g.o>
3 > wrote:
4 > > On 12/11/19 9:58 AM, Michał Górny wrote:
5 > > > Append RESTRICT="!test? ( test )" in the default case when
6 > > > virtualx
7 > > > is conditional to USE=test. This fixes 440 MissingTestRestrict
8 > > > warnings.
9 > > >
10 > > > Signed-off-by: Michał Górny <mgorny@g.o>
11 > > > ---
12 > > > eclass/virtualx.eclass | 2 ++
13 > > > 1 file changed, 2 insertions(+)
14 > > >
15 > > > diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
16 > > > index 40eeea5463bc..6aba6bf488dd 100644
17 > > > --- a/eclass/virtualx.eclass
18 > > > +++ b/eclass/virtualx.eclass
19 > > > @@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
20 > > > fi
21 > > > RDEPEND=""
22 > > > IUSE="${VIRTUALX_REQUIRED}"
23 > > > + [[ ${VIRTUALX_REQUIRED} == test ]] &&
24 > > > + RESTRICT+=" !test? ( test )"
25 > > > ;;
26 > > > esac
27 > > >
28 > > >
29 > >
30 > > Is there a better way to address this than editing a ton of
31 > > eclasses
32 > > independently?
33 >
34 > Not really.
35 >
36
37 Seems a good candidate for a future EAPI

Replies