Gentoo Archives: gentoo-dev

From: Matt Turner <mattst88@g.o>
To: Ulrich Mueller <ulm@g.o>
Cc: gentoo development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files
Date: Wed, 20 Feb 2019 06:50:55
Message-Id: CAEdQ38H77ic7VOowZaA5Ttj28gW2-RT89-eEdpT94REeca+UrQ@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files by Ulrich Mueller
1 On Tue, Feb 19, 2019 at 10:21 PM Ulrich Mueller <ulm@g.o> wrote:
2 >
3 > >>>>> On Wed, 20 Feb 2019, Matt Turner wrote:
4 >
5 > > # Don't install libtool archives (even for modules)
6 > > - prune_libtool_files --all
7 > > + find "${D}" -name '*.la' -delete || die
8 >
9 > Maybe restrict removal to regular files, i.e. add "-type f"?
10
11 Is that ever a problem? The 'find ...' that I replaced
12 prune_libtool_files is a verbatim copy of what ltprune.eclass says to
13 use instead:
14
15 # Discouraged. Whenever possible, please use much simpler:
16 # @CODE
17 # find "${D}" -name '*.la' -delete || die
18 # @CODE
19
20 grepping the repo, I think a strong case can be made in favor of
21 ltprune.eclass given the wide variety of ways this is open coded...