| 1 |
On Sun, 30 Jul 2017 14:32:53 +0300 |
| 2 |
Andrew Savchenko <bircoph@g.o> wrote: |
| 3 |
|
| 4 |
> For EAPI 6+ java-pkg-opt-2_src_prepare() has eapply_user call via |
| 5 |
> java-utils-2_src_prepare() from java-utils-2.eclass. But |
| 6 |
> java-utils-2_src_prepare() call is conditional and in case when |
| 7 |
> package is build with USE=-java java-utils-2_src_prepare() is not |
| 8 |
> called, hence eapply_user is not called in src_prepare phase and |
| 9 |
> ebuild fails. |
| 10 |
> |
| 11 |
> The following patch fixes this by calling eapply_user if java USE |
| 12 |
> is disabled _and_ EAPI is 6+. |
| 13 |
|
| 14 |
This makes sense so no problem here. |
| 15 |
|
| 16 |
> [pedantic mode on] |
| 17 |
> Strictly speaking when EAPI is other than [0-5]. The way java-* |
| 18 |
> eclasses are now, they assume ![0-5] == 6+. It may be speculated |
| 19 |
> that this is not entirely correct and many other eclasses |
| 20 |
> explicitly deny all unknown EAPIs. If someone is interesting in |
| 21 |
> fixing this issue, please handle it with the java team and do not |
| 22 |
> mix it into the problem described at the beginning. My goal now is |
| 23 |
> to fix eapply_user issue which cases trouble for any EAPI 6 |
| 24 |
> packages with optional java support and default src_prepare() at |
| 25 |
> the ebuild scope. |
| 26 |
> [pedantic mode off] |
| 27 |
|
| 28 |
Agreed. I don't think java-utils-2_src_prepare() should be changed in |
| 29 |
this regard as the behaviour may continue to be correct but the eclass |
| 30 |
should have a global EAPI check that forbids anything beyond 6 like |
| 31 |
other eclasses do. |
| 32 |
|
| 33 |
-- |
| 34 |
James Le Cuirot (chewi) |
| 35 |
Gentoo Linux Developer |
Archives