Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: mrueg@g.o
Cc: gentoo-dev@l.g.o, python@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in kde-misc/synaptiks: synaptiks-0.8.1-r3.ebuild ChangeLog
Date: Fri, 16 Aug 2013 17:33:28
Message-Id: 520E625B.5010503@gentoo.org
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Please let the python herd review distutils-r1 conversions until you
5 feel safe about it.
6
7
8 On 08/16/2013 11:54 AM, Manuel Rueger (mrueg) wrote:
9 > Index: synaptiks-0.8.1-r3.ebuild
10 > ===================================================================
11 >
12 >
13 # Copyright 1999-2013 Gentoo Foundation
14 > # Distributed under the terms of the GNU General Public License v2
15 > # $Header:
16 > /var/cvsroot/gentoo-x86/kde-misc/synaptiks/synaptiks-0.8.1-r3.ebuild,v
17 > 1.1 2013/08/16 09:54:19 mrueg Exp $
18 >
19 > EAPI=5
20 >
21 > KDE_HANDBOOK=optional PYTHON_COMPAT=( python2_6 python2_7 ) inherit
22 > kde4-base distutils-r1
23 >
24 > DESCRIPTION="Touchpad configuration and management tool for KDE"
25 > HOMEPAGE="http://synaptiks.readthedocs.org"
26 > SRC_URI="mirror://pypi/s/${PN}/${P}.tar.bz2"
27 >
28 > LICENSE="BSD-2" SLOT="4" KEYWORDS="~amd64 ~x86" IUSE="debug doc
29 > +upower"
30 >
31
32 You are missing [${PYTHON_USEDEP}] all over the place.
33 The add_kdebase_dep pykde4 seems to break it further.
34
35 > RDEPEND=" >=dev-python/PyQt4-4.7 >=dev-python/pyudev-0.8[pyqt4]
36 > dev-python/setuptools $(add_kdebase_dep pykde4) || ( (
37 > $(add_kdebase_dep kdesdk-scripts) ) ( $(add_kdebase_dep
38 > kde-dev-scripts) ) ) virtual/python-argparse
39 > >=x11-drivers/xf86-input-synaptics-1.3 >=x11-libs/libXi-1.4
40 > x11-libs/libXtst upower? ( dev-python/dbus-python sys-power/upower
41 > )" DEPEND="${RDEPEND} app-text/docbook-xsl-stylesheets
42 > sys-devel/gettext
43
44 These might not need [${PYTHON_USEDEP}] if scripts are called directly
45 only.
46
47 > doc? ( dev-python/sphinx dev-python/sphinxcontrib-issuetracker )"
48 >
49
50 You overwrite distutils-r1_src_prepare, that leads to:
51 * PATCHES array does not work
52 * epatch_user is disabled
53 * DISTUTILS_IN_SOURCE_BUILD would not work
54 * _disable_ez_setup is not carried out
55
56 > src_prepare() { epatch "${FILESDIR}/${P}-templatesfix.patch"\
57 > "${FILESDIR}/${PN}-0.8.1-removedfeatures.patch" }
58 >
59 > src_compile() { distutils-r1_src_compile if use doc; then einfo
60 > "Generation of documentation" pushd doc > /dev/null sphinx-build .
61 > _build || die popd > /dev/null fi }
62 >
63 > src_install() { distutils-r1_src_install if use doc; then dohtml -r
64 > doc/_build/* fi }
65 >
66 >
67 >
68 >
69
70 -----BEGIN PGP SIGNATURE-----
71 Version: GnuPG v2.0.20 (GNU/Linux)
72 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
73
74 iQEcBAEBAgAGBQJSDmJbAAoJEFpvPKfnPDWzyDsIAJZ6aSG8kA1BnI+3v0LE4Sjm
75 8Q7hQvUsY2Ww+Dh/H6NYysftURnZDo/zq/PGiAJSTRAsbCSI13iWRTO9c7oq3ZwF
76 zQAT+ur+ThHRd77eKHh3pzMX7zIlad/ZT+NPNaGuBNNGXL021YaPIl1roDnTQVDD
77 rFYTgrb5A9s7NxF9u4vF+mTF9NYkSvHP4Em4QYVeGeHIrt/lfvBCiJ5r8rAwYb8b
78 oVDX6fGcjmneEoTD2VfRb3GVHJSRtRTXLqXyLkk9KUoyPMR7PnJrDRBMVm7ewNqL
79 PHwqfnUu9u5FKxYzZ8grJDChmA8GOku8MUufVrAW5mzHQSMQNRqa8GfowefvSgg=
80 =FohH
81 -----END PGP SIGNATURE-----