1 |
>>>>> On Sun, 20 Oct 2019, David Seifert wrote: |
2 |
|
3 |
>> > - [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation |
4 |
>> > failed" ; } # TODO old EAPI cleanup |
5 |
>> > + einstalldocs |
6 |
>> > |
7 |
>> > # install common docs |
8 |
>> > - for commondoc in COPYRIGHT README{,.md,.txt} NEWS AUTHORS BUGS |
9 |
>> > ChangeLog FONTLOG.txt; do |
10 |
>> > + for commondoc in COPYRIGHT FONTLOG.txt; do |
11 |
>> > [[ -s ${commondoc} ]] && dodoc ${commondoc} |
12 |
>> > done |
13 |
|
14 |
>> This changes the set of installed files, if the DOCS variable is |
15 |
>> defined. Is that intentional? |
16 |
|
17 |
> You mean if it's *not* defined? |
18 |
|
19 |
No, if it *is* defined. For example, if an ebuild defines DOCS but |
20 |
doesn't include README.txt in the list, then that file was previously |
21 |
being installed, but isn't any longer with the eclass change. |
22 |
|
23 |
>> This doesn't change any functionality, but it adds an overlong line |
24 |
>> for no good reason. |
25 |
|
26 |
> The idea was to avoid if statements if you can use the more succinct |
27 |
> form. |
28 |
|
29 |
Then at least wrap the long line. Still, I doubt that it will improve |
30 |
readability, as compared to the original if statement. |
31 |
|
32 |
Ulrich |