Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: William Hubbs <williamh@g.o>
Cc: gentoo development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] newsitem: important fstab update
Date: Tue, 25 Oct 2016 21:12:45
Message-Id: 20161025231219.7bf8e0ce.mgorny@gentoo.org
In Reply to: [gentoo-dev] newsitem: important fstab update by William Hubbs
1 On Tue, 25 Oct 2016 12:01:06 -0500
2 William Hubbs <williamh@g.o> wrote:
3
4 > Title: Inportant fstab update
5 > Author: William Hubbs <williamh@g.o>
6 > Content-Type: text/plain
7 > Posted: 2016-10-28
8 > Revision: 1
9 > News-Item-Format: 1.0
10 >
11 > If you are not using /dev/disk/by-* paths in fstab, you do not need to
12 > take any action for this news item.
13 >
14 > If you are, it is very critical that you update fstab AS SOON AS
15 > POSSIBLE. Your system will become unbootable in the future if you do
16 > not do so.
17
18 I don't think this is a good way to start any text. You should start
19 with a short introduction on what's happening, when and how.
20
21 Right now the news item sounds like the world is going to suddenly fall
22 apart for no specific reason. Reading it, I don't know what's changing,
23 and how to check if it impacts me already (i.e. if it's 'do not
24 reboot' kind of problem) and if it will impact me at all.
25
26 > You need to replace the /dev/disk/by-* paths in your fstab with the
27 > equivalent information from the output of the blkid utility.
28
29 This is at least unclear, if not misguiding. I read it as 'blkid will
30 give you fs info'. However, you're not telling me which of those
31 information I can use and how. I should also point out that blkid
32 supports multiple output formats.
33
34 I think it would be better if you explicitly listed the thingies
35 supported by mount(1).
36
37 > For example, here is out from blkid on my system:
38 >
39 > # blkid
40 >
41 > /dev/sda2: LABEL="boot" UUID="371432e9-7e6c-4205-9d4e-b23f6212e54b" TYPE="ext2" PARTLABEL="boot" PARTUUID="2451c4a9-0405-425e-8d53-4567beae8651"
42 > /dev/sda3: LABEL="swap" UUID="d579b037-615c-441f-8f83-03e3c4919c21" TYPE="swap" PARTLABEL="swap" PARTUUID="14c0d838-6dc5-4fdb-9a9d-c9523acdadc7"
43 > /dev/sda4: LABEL="root" UUID="5c496429-c836-4b23-9b11-7efd609c7cde" TYPE="ext4" PARTLABEL="rootfs" PARTUUID="8a9765a4-7a20-4fa4-87e2-7a64d782e0d0"
44 > /dev/sda5: LABEL="home" UUID="bb63928e-67c0-4522-b4a0-66be507c2c2f" TYPE="ext4" PARTLABEL="home" PARTUUID="000848d8-b51b-4671-8754-6d3b0c8df465"
45 > /dev/sda6: LABEL="var" UUID="fcb8046b-283b-45c0-a2c0-ae1001bebf82" TYPE="ext4" PARTLABEL="var" PARTUUID="e1d8ccf6-3523-4c13-baae-e674ee0b43bf"
46 > /dev/sda1: PARTLABEL="grub" PARTUUID="700e8338-399f-4d33-9e15-73c85b136f3d"
47 >
48 > My fstab can use any of the labels or ids, so I use labels:
49 >
50 > LABEL=boot /boot ext2 defaults 1 2
51 > LABEL=swap none swap sw 0 0
52 > LABEL=root / ext4 defaults 0 1
53 > LABEL=home /home ext4 defaults 0 1
54 > LABEL=var /var ext4 defaults 0 1
55
56 I'm afraid those examples are not really readable. Furthermore, I don't
57 see much point in pasting the whole fstab if all entries use LABEL=.
58 Try to keep them below 72 (or 80?) chars, skip blkid or paste just one
59 entry (wrapped), paste a minimal fstab just as example how the tags can
60 be used.
61
62 --
63 Best regards,
64 Michał Górny
65 <http://dev.gentoo.org/~mgorny/>

Replies

Subject Author
Re: [gentoo-dev] newsitem: important fstab update Ian Stakenvicius <axs@g.o>