Re: [gentoo-dev] [PATCH 3/3] app-emulation/gallium-nine-standalone: use meson-array

[William Hubbs]

On Fri, Dec 11, 2020 at 06:17:44PM -0500, Mike Gilbert wrote:
> Bug: https://bugs.gentoo.org/759433
> Signed-off-by: Mike Gilbert <floppym@g.o>
> ---
>  .../gallium-nine-standalone-0.7.ebuild                        | 4 ++--
>  .../gallium-nine-standalone-9999.ebuild                       | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/app-emulation/gallium-nine-standalone/gallium-nine-standalone-0.7.ebuild b/app-emulation/gallium-nine-standalone/gallium-nine-standalone-0.7.ebuild
> index 3e96326a2fc8..9e075e1f5edb 100644
> --- a/app-emulation/gallium-nine-standalone/gallium-nine-standalone-0.7.ebuild
> +++ b/app-emulation/gallium-nine-standalone/gallium-nine-standalone-0.7.ebuild
> @@ -65,8 +65,8 @@ src_prepare() {
>
>  		sed \
>  			-e "s!@PKG_CONFIG@!$(tc-getPKG_CONFIG)!" \
> -			-e "s!@CFLAGS@!$(_meson_env_array "${CFLAGS} '-DG9DLL=${g9dll}'")!" \
> -			-e "s!@LDFLAGS@!$(_meson_env_array "${LDFLAGS}")!" \
> +			-e "s!@CFLAGS@!$(meson-array "${CFLAGS} '-DG9DLL=${g9dll}'")!" \
> +			-e "s!@LDFLAGS@!$(meson-array "${LDFLAGS}")!" \
>  			-e "s!@PKG_CONFIG_LIBDIR@!${PKG_CONFIG_LIBDIR:-${ESYSROOT}/usr/$(get_libdir)/pkgconfig}!" \
>  			${file}.in > ${file} || die
>  	}
> diff --git a/app-emulation/gallium-nine-standalone/gallium-nine-standalone-9999.ebuild b/app-emulation/gallium-nine-standalone/gallium-nine-standalone-9999.ebuild
> index 3e96326a2fc8..9e075e1f5edb 100644
> --- a/app-emulation/gallium-nine-standalone/gallium-nine-standalone-9999.ebuild
> +++ b/app-emulation/gallium-nine-standalone/gallium-nine-standalone-9999.ebuild
> @@ -65,8 +65,8 @@ src_prepare() {
>
>  		sed \
>  			-e "s!@PKG_CONFIG@!$(tc-getPKG_CONFIG)!" \
> -			-e "s!@CFLAGS@!$(_meson_env_array "${CFLAGS} '-DG9DLL=${g9dll}'")!" \
> -			-e "s!@LDFLAGS@!$(_meson_env_array "${LDFLAGS}")!" \
> +			-e "s!@CFLAGS@!$(meson-array "${CFLAGS} '-DG9DLL=${g9dll}'")!" \
> +			-e "s!@LDFLAGS@!$(meson-array "${LDFLAGS}")!" \
>  			-e "s!@PKG_CONFIG_LIBDIR@!${PKG_CONFIG_LIBDIR:-${ESYSROOT}/usr/$(get_libdir)/pkgconfig}!" \
>  			${file}.in > ${file} || die
>  	}
> --
> 2.29.2

# @FUNCTION: _meson_env_array
# @INTERNAL
# @DESCRIPTION:
# Parses the command line flags and converts them into an array suitable for
# use in a cross file.

The _meson_env_array function is not part of the API for the meson
eclass.

Can you tell me more about gallium-nine-standalone and what it needs
from the meson eclass? We can probably provide functions that return the
info it needs.

Thanks,

William