Re: [gentoo-dev] [RFC] office-ext.eclass

[Tomáš Chvátal]

Dne 29.8.2011 09:24, Michał Górny napsal(a):
> On Mon, 29 Aug 2011 09:11:31 +0200
> Tomáš Chvátal<scarabeus@g.o>  wrote:
>
>> # @ECLASS: openoffice.eclass
>
> Ekhm.
>
> Also I think, you should use 'openoffice' in the name anyway,
> or 'libreoffice', or whatever suggesting the actual office packages
> branch.
>
>> # @ECLASS-VARIABLE: OOO_EXTENSIONS
>> # @REQUIRED
>> # @DEFAULT_UNSET
>
> I don't think you're supposed to mix these two.
Why? It make perfect sense, it is both required and empty by default.
>
>> openoffice-ext_get_implementation() {
>> 	debug-print-function ${FUNCNAME} "$@"
>> 	local implementations="libreoffice openoffice"
>
> Be modern, use an array :D.
Sure why not.
>
>> 	die "Could not determine office implementation!"
>
> That sounds weird.
Why, it returns in the loop above that or thigger this code.
I consider it nicer than adding yet another useless condition.
>
>> }
>
>> openoffice-ext_src_install() {
>> 	debug-print-function ${FUNCNAME} "$@"
>> 	local i
>>
>> 	insinto
>> $(openoffice-ext_get_implementation)/share/extension/install/ for i
>> in ${OOO_EXTENSIONS}; do doins ${i}
>> 	done
>
> I think you should use local scope if you're intending to use 'insinto'.
>
What? I really don't get this :)

Updated eclass attached.