1 |
Dne 29.8.2011 09:24, Michał Górny napsal(a): |
2 |
> On Mon, 29 Aug 2011 09:11:31 +0200 |
3 |
> Tomáš Chvátal<scarabeus@g.o> wrote: |
4 |
> |
5 |
>> # @ECLASS: openoffice.eclass |
6 |
> |
7 |
> Ekhm. |
8 |
> |
9 |
> Also I think, you should use 'openoffice' in the name anyway, |
10 |
> or 'libreoffice', or whatever suggesting the actual office packages |
11 |
> branch. |
12 |
> |
13 |
>> # @ECLASS-VARIABLE: OOO_EXTENSIONS |
14 |
>> # @REQUIRED |
15 |
>> # @DEFAULT_UNSET |
16 |
> |
17 |
> I don't think you're supposed to mix these two. |
18 |
Why? It make perfect sense, it is both required and empty by default. |
19 |
> |
20 |
>> openoffice-ext_get_implementation() { |
21 |
>> debug-print-function ${FUNCNAME} "$@" |
22 |
>> local implementations="libreoffice openoffice" |
23 |
> |
24 |
> Be modern, use an array :D. |
25 |
Sure why not. |
26 |
> |
27 |
>> die "Could not determine office implementation!" |
28 |
> |
29 |
> That sounds weird. |
30 |
Why, it returns in the loop above that or thigger this code. |
31 |
I consider it nicer than adding yet another useless condition. |
32 |
> |
33 |
>> } |
34 |
> |
35 |
>> openoffice-ext_src_install() { |
36 |
>> debug-print-function ${FUNCNAME} "$@" |
37 |
>> local i |
38 |
>> |
39 |
>> insinto |
40 |
>> $(openoffice-ext_get_implementation)/share/extension/install/ for i |
41 |
>> in ${OOO_EXTENSIONS}; do doins ${i} |
42 |
>> done |
43 |
> |
44 |
> I think you should use local scope if you're intending to use 'insinto'. |
45 |
> |
46 |
What? I really don't get this :) |
47 |
|
48 |
Updated eclass attached. |