Gentoo Archives: gentoo-dev

From: Mike Pagano <mpagano@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Add required @USAGE documentation to functions.
Date: Tue, 13 Dec 2016 00:46:41
Message-Id: d2572b3d-85e1-f403-c93d-26769f98923c@gentoo.org
1 According to PMS, @USAGE is required for functions.
2 This patch only touches comments and no code has been modified.
3
4 ---
5 eclass/kernel-2.eclass | 38 ++++++++++++++++++++++++++++++++++----
6 1 file changed, 34 insertions(+), 4 deletions(-)
7
8 diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
9 index b19a396..99449a6 100644
10 --- a/eclass/kernel-2.eclass
11 +++ b/eclass/kernel-2.eclass
12 @@ -128,8 +128,6 @@
13 # @DESCRIPTION:
14 # If set, this kernel is unsupported by Gentoo Security
15 # to the current eclass maintainer :)
16 -# added functionality:
17 -# unipatch - a flexible, singular method to extract, add and
18 remove patches.
19
20 # @ECLASS-VARIABLE: K_DEBLOB_AVAILABLE
21 # @DEFAULT_UNSET
22 @@ -241,6 +239,7 @@ RESTRICT="binchecks strip"
23
24
25 # @FUNCTION: debug-print-kernel2-variables
26 +# @USAGE:
27 # @DESCRIPTION:
28 # this function exists only to help debug kernel-2.eclass
29 # if you are adding new functionality in, put a call to it
30 @@ -255,6 +254,7 @@ debug-print-kernel2-variables() {
31 }
32
33 # @FUNCTION: handle_genpatches
34 +# @USAGE: [--set-unipatch-list]
35 # @DESCRIPTION:
36 # add genpatches to list of patches to apply uf wanted
37
38 @@ -312,6 +312,7 @@ handle_genpatches() {
39 }
40
41 # @FUNCTION: detect_version
42 +# @USAGE:
43 # @DESCRIPTION:
44 # this function will detect and set
45 # - OKV: Original Kernel Version (2.6.0/2.6.0-test11)
46 @@ -543,6 +544,7 @@ detect_version() {
47 }
48
49 # @FUNCTION: kernel_is
50 +# @USAGE: <conditional version | version>
51 # @DESCRIPTION:
52 # user for comparing kernel versions
53 # or just identifying a version
54 @@ -576,6 +578,7 @@ kernel_is() {
55 }
56
57 # @FUNCTION: kernel_is_2_4
58 +# @USAGE:
59 # @DESCRIPTION:
60 # return true if kernel is version 2.4
61 kernel_is_2_4() {
62 @@ -583,6 +586,7 @@ kernel_is_2_4() {
63 }
64
65 # @FUNCTION: kernel_is_2_6
66 +# @USAGE:
67 # @DESCRIPTION:
68 # return true if kernel is version 2.6
69 kernel_is_2_6() {
70 @@ -677,6 +681,7 @@ fi
71 # Cross-compile support functions
72
73 # @FUNCTION: kernel_header_destdir
74 +# @USAGE:
75 # @DESCRIPTION:
76 # return header destination directory
77 kernel_header_destdir() {
78 @@ -686,6 +691,7 @@ kernel_header_destdir() {
79 }
80
81 # @FUNCTION: cross_pre_c_headers
82 +# @USAGE:
83 # @DESCRIPTION:
84 # set use if neccesary for cross compile support
85 cross_pre_c_headers() {
86 @@ -693,6 +699,7 @@ cross_pre_c_headers() {
87 }
88
89 # @FUNCTION: env_setup_xmakeopts
90 +# @USAGE:
91 # @DESCRIPTION:
92 # set the ARCH/CROSS_COMPILE when cross compiling
93
94 @@ -712,6 +719,7 @@ env_setup_xmakeopts() {
95 }
96
97 # @FUNCTION: unpack_2_4
98 +# @USAGE:
99 # @DESCRIPTION:
100 # unpack and generate .config for 2.4 kernels
101
102 @@ -725,6 +733,7 @@ unpack_2_4() {
103 }
104
105 # @FUNCTION: unpack_2_6
106 +# @USAGE:
107 # @DESCRIPTION:
108 # unpack and generate .config for 2.6 kernels
109
110 @@ -750,6 +759,7 @@ unpack_2_6() {
111 }
112
113 # @FUNCTION: universal_unpack
114 +# @USAGE:
115 # @DESCRIPTION:
116 # unpack kernel sources
117
118 @@ -793,6 +803,7 @@ universal_unpack() {
119 }
120
121 # @FUNCTION: unpack_set_extraversion
122 +# @USAGE:
123 # @DESCRIPTION:
124 # handle EXTRAVERSION
125
126 @@ -803,6 +814,7 @@ unpack_set_extraversion() {
127 }
128
129 # @FUNCTION: unpack_fix_install_path
130 +# @USAGE:
131 # @DESCRIPTION:
132 # Should be done after patches have been applied
133 # Otherwise patches that modify the same area of Makefile will fail
134 @@ -815,6 +827,7 @@ unpack_fix_install_path() {
135 # Compile Functions
136
137 # @FUNCTION: compile_headers
138 +# @USAGE:
139 # @DESCRIPTION:
140 # header compilation
141
142 @@ -871,6 +884,7 @@ compile_headers() {
143 }
144
145 # @FUNCTION: compile_headers_tweak_config
146 +# @USAGE:
147 # @DESCRIPTION:
148 # some targets can be very very picky, so let's finesse the
149 # .config based upon any info we may have
150 @@ -890,6 +904,7 @@ compile_headers_tweak_config() {
151 # install functions
152
153 # @FUNCTION: install_universal
154 +# @USAGE:
155 # @DESCRIPTION:
156 # Fix permissions in tarball
157
158 @@ -901,6 +916,7 @@ install_universal() {
159 }
160
161 # @FUNCTION: install_headers
162 +# @USAGE:
163 # @DESCRIPTION:
164 # Install headers
165
166 @@ -940,6 +956,7 @@ install_headers() {
167 }
168
169 # @FUNCTION: install_sources
170 +# @USAGE:
171 # @DESCRIPTION:
172 # Install sources
173
174 @@ -978,6 +995,7 @@ install_sources() {
175 }
176
177 # @FUNCTION: preinst_headers
178 +# @USAGE:
179 # @DESCRIPTION:
180 # Headers preinst steps
181
182 @@ -988,6 +1006,7 @@ preinst_headers() {
183 }
184
185 # @FUNCTION: postinst_sources
186 +# @USAGE:
187 # @DESCRIPTION:
188 # Sources post installation function.
189 # see inline comments
190 @@ -1082,6 +1101,7 @@ postinst_sources() {
191 # pkg_setup functions
192
193 # @FUNCTION: setup_headers
194 +# @USAGE:
195 # @DESCRIPTION:
196 # Determine if ${PN} supports arch
197
198 @@ -1101,6 +1121,7 @@ setup_headers() {
199 }
200
201 # @FUNCTION: unipatch
202 +# @USAGE: <list of patches to apply>
203 # @DESCRIPTION:
204 # Universal function that will apply patches to source
205
206 @@ -1364,9 +1385,8 @@ unipatch() {
207 }
208
209 # @FUNCTION: getfilevar
210 +# @USAGE: <variable> <configfile>
211 # @DESCRIPTION:
212 -# getfilevar accepts 2 vars as follows:
213 -# getfilevar <VARIABLE> <CONFIGFILE>
214 # pulled from linux-info
215
216 getfilevar() {
217 @@ -1392,6 +1412,7 @@ getfilevar() {
218 }
219
220 # @FUNCTION: detect_arch
221 +# @USAGE:
222 # @DESCRIPTION:
223 # This function sets ARCH_URI and ARCH_PATCH
224 # with the neccessary info for the arch sepecific compatibility
225 @@ -1425,6 +1446,7 @@ detect_arch() {
226 }
227
228 # @FUNCTION: headers___fix
229 +# @USAGE:
230 # @DESCRIPTION:
231 # Voodoo to partially fix broken upstream headers.
232 # note: do not put inline/asm/volatile together (breaks "inline asm
233 volatile")
234 @@ -1440,6 +1462,7 @@ headers___fix() {
235 }
236
237 # @FUNCTION: kernel-2_src_unpack()
238 +# @USAGE:
239 # @DESCRIPTION:
240 # unpack sources, handle genpatches, deblob
241
242 @@ -1501,6 +1524,7 @@ kernel-2_src_unpack() {
243 }
244
245 # @FUNCTION: kernel-2_src_prepare
246 +# @USAGE:
247 # @DESCRIPTION:
248 # Apply any user patches
249
250 @@ -1516,6 +1540,7 @@ kernel-2_src_prepare() {
251 }
252
253 # @FUNCTION: kernel-2_src_compile
254 +# @USAGE:
255 # @DESCRIPTION:
256 # conpile headers or run deblob script
257
258 @@ -1531,6 +1556,7 @@ kernel-2_src_compile() {
259 }
260
261 # @FUNCTION: kernel-2_src_test
262 +# @USAGE:
263 # @DESCRIPTION:
264 # if you leave it to the default src_test, it will run make to
265 # find whether test/check targets are present; since "make test"
266 @@ -1549,6 +1575,7 @@ kernel-2_pkg_preinst() {
267 }
268
269 # @FUNCTION: kernel-2_src_install
270 +# @USAGE:
271 # @DESCRIPTION:
272 # Install headers or sources dependant on ETYPE
273
274 @@ -1559,6 +1586,7 @@ kernel-2_src_install() {
275 }
276
277 # @FUNCTION: kernel-2_pkg_postinst
278 +# @USAGE:
279 # @DESCRIPTION:
280 # call postinst_sources for ETYPE = sources
281
282 @@ -1567,6 +1595,7 @@ kernel-2_pkg_postinst() {
283 }
284
285 # @FUNCTION: kernel-2_pkg_setup
286 +# @USAGE:
287 # @DESCRIPTION:
288 # check for supported kernel version, die if ETYPE is unknown, call
289 setup_headers
290 # if necessary
291 @@ -1597,6 +1626,7 @@ kernel-2_pkg_setup() {
292 }
293
294 # @FUNCTION: kernel-2_pkg_postrm
295 +# @USAGE:
296 # @DESCRIPTION:
297 # Notify the user that after a depclean, there may be sources
298 # left behind that need to be manually cleaned
299 --
300 2.7.3

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies