Gentoo Archives: gentoo-dev

From: Mike Pagano <mpagano@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] [PATCH] eclass/kernel-2.eclass: Remove use of tr in global scope
Date: Thu, 31 Aug 2017 00:02:25
Message-Id: 22c1f99c-dc7b-a35e-e765-32e7e54e3f94@gentoo.org
1 As per PMS remove calls to external command 'tr' in global scope
2 See bug #629106
3
4 Signed-off-by: Mike Pagano <mpagano@g.o>
5 ---
6 eclass/kernel-2.eclass | 8 +++++---
7 1 file changed, 5 insertions(+), 3 deletions(-)
8
9 diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
10 index 09409ab1f..cdc8c4043 100644
11 --- a/eclass/kernel-2.eclass
12 +++ b/eclass/kernel-2.eclass
13 @@ -1410,7 +1410,7 @@ getfilevar() {
14
15 detect_arch() {
16
17 - local ALL_ARCH LOOP_ARCH COMPAT_URI i
18 + local ALL_ARCH LOOP_ARCH COMPAT_URI TC_ARCH_KERNEL
19
20 # COMPAT_URI is the contents of ${ARCH}_URI
21 # ARCH_URI is the URI for all the ${ARCH}_URI patches
22 @@ -1418,6 +1418,7 @@ detect_arch() {
23
24 ARCH_URI=""
25 ARCH_PATCH=""
26 + TC_ARCH_KERNEL=""
27 ALL_ARCH="ALPHA AMD64 ARM HPPA IA64 M68K MIPS PPC PPC64 S390 SH SPARC X86"
28
29 for LOOP_ARCH in ${ALL_ARCH}; do
30 @@ -1425,9 +1426,10 @@ detect_arch() {
31 COMPAT_URI="${!COMPAT_URI}"
32
33 [[ -n ${COMPAT_URI} ]] && \
34 - ARCH_URI="${ARCH_URI} $(echo ${LOOP_ARCH} | tr '[:upper:]' '[:lower:]')? ( ${COMPAT_URI} )"
35 + ARCH_URI="${ARCH_URI} ${LOOP_ARCH,,}? ( ${COMPAT_URI} )"
36
37 - if [[ ${LOOP_ARCH} == "$(echo $(tc-arch-kernel) | tr '[:lower:]' '[:upper:]')" ]]; then
38 + TC_ARCH_KERNEL=$(tc-arch-kernel);
39 + if [[ ${LOOP_ARCH} == ${TC_ARCH_KERNEL^^} ]]; then

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies