Gentoo Archives: gentoo-dev

From: Jakov Smolic <jakov.smolic@×××××××.hr>
To: gentoo-dev@l.g.o
Cc: Luka Perkov <luka.perkov@×××××××.hr>, proxy-maint@g.o, klondike@g.o
Subject: [gentoo-dev] Re: [PATCHv2 3/4] dev-libs/json-c: Change USE to cpu_flags_x86_rdrand
Date: Mon, 13 Jul 2020 19:39:16
Message-Id: CAJRasQXU0+fPKWbf2VVK9JuJq5zknJVZu6yqXypY-G3j5VAZJQ@mail.gmail.com
In Reply to: [gentoo-dev] [PATCHv2 3/4] dev-libs/json-c: Change USE to cpu_flags_x86_rdrand by "Francisco Blas Izquierdo Riera (klondike)"
1 LGTM, thank you!
2 I just left a comment on the pull request to close the related bug [1]
3 via the commit.
4
5 Best regards,
6 Jakov Smolic
7
8 [1] https://bugs.gentoo.org/724354
9
10 On Mon, Jul 13, 2020 at 7:29 PM Francisco Blas Izquierdo Riera
11 (klondike) <klondike@g.o> wrote:
12 >
13 >
14 > Package-Manager: Portage-2.3.99, Repoman-2.3.23
15 > Signed-off-by: Francisco Blas Izquierdo Riera (klondike) <klondike@g.o>
16 > ---
17 > dev-libs/json-c/json-c-0.14-r3.ebuild | 4 ++--
18 > dev-libs/json-c/json-c-9999.ebuild | 4 ++--
19 > dev-libs/json-c/metadata.xml | 3 ---
20 > 3 files changed, 4 insertions(+), 7 deletions(-)
21 >
22 > diff --git a/dev-libs/json-c/json-c-0.14-r3.ebuild b/dev-libs/json-c/json-c-0.14-r3.ebuild
23 > index 0d4ff648a36..0eae6655775 100644
24 > --- a/dev-libs/json-c/json-c-0.14-r3.ebuild
25 > +++ b/dev-libs/json-c/json-c-0.14-r3.ebuild
26 > @@ -13,7 +13,7 @@ SRC_URI="https://s3.amazonaws.com/json-c_releases/releases/${P}.tar.gz"
27 > LICENSE="MIT"
28 > SLOT="0/5"
29 > KEYWORDS="~alpha amd64 arm arm64 hppa ~ia64 ~mips ppc ppc64 s390 sparc x86 ~amd64-linux ~x86-linux ~ppc-macos"
30 > -IUSE="cpu-flags-x86-rdrand doc static-libs threads"
31 > +IUSE="cpu_flags_x86_rdrand doc static-libs threads"
32 >
33 > PATCHES=(
34 > "${FILESDIR}/${PN}-0.14-cmake-static-libs.patch"
35 > @@ -34,7 +34,7 @@ multilib_src_configure() {
36 > -DBUILD_DOCUMENTATION=$(multilib_native_usex doc)
37 > -DBUILD_STATIC_LIBS=$(usex static-libs)
38 > -DDISABLE_WERROR=ON
39 > - -DENABLE_RDRAND=$(usex cpu-flags-x86-rdrand)
40 > + -DENABLE_RDRAND=$(usex cpu_flags_x86_rdrand)
41 > -DENABLE_THREADING=$(usex threads)
42 > )
43 >
44 > diff --git a/dev-libs/json-c/json-c-9999.ebuild b/dev-libs/json-c/json-c-9999.ebuild
45 > index 51583e0b0ad..b39b8ba779c 100644
46 > --- a/dev-libs/json-c/json-c-9999.ebuild
47 > +++ b/dev-libs/json-c/json-c-9999.ebuild
48 > @@ -12,7 +12,7 @@ EGIT_REPO_URI="https://github.com/json-c/json-c.git"
49 >
50 > LICENSE="MIT"
51 > SLOT="0/5"
52 > -IUSE="cpu-flags-x86-rdrand doc static-libs threads"
53 > +IUSE="cpu_flags_x86_rdrand doc static-libs threads"
54 >
55 > MULTILIB_WRAPPED_HEADERS=(
56 > /usr/include/json-c/config.h
57 > @@ -27,7 +27,7 @@ multilib_src_configure() {
58 > -DBUILD_DOCUMENTATION=$(multilib_native_usex doc)
59 > -DDISABLE_WERROR=ON
60 > -DENABLE_THREADING=$(usex threads)
61 > - -DENABLE_RDRAND=$(usex cpu-flags-x86-rdrand)
62 > + -DENABLE_RDRAND=$(usex cpu_flags_x86_rdrand)
63 > -DBUILD_STATIC_LIBS=$(usex static-libs)
64 > )
65 >
66 > diff --git a/dev-libs/json-c/metadata.xml b/dev-libs/json-c/metadata.xml
67 > index 4165aa7d278..ca10c6aa7ae 100644
68 > --- a/dev-libs/json-c/metadata.xml
69 > +++ b/dev-libs/json-c/metadata.xml
70 > @@ -13,9 +13,6 @@
71 > <email>proxy-maint@g.o</email>
72 > <name>Proxy Maintainers</name>
73 > </maintainer>
74 > - <use>
75 > - <flag name="cpu-flags-x86-rdrand">Enable RDRAND Hardware RNG Hash Seed</flag>
76 > - </use>
77 > <longdescription lang="en">
78 > "A JSON implementation in C" is probably the better description, and then
79 > "JSON-C implements a reference counting object model that allows you to
80 > --
81 > 2.26.2
82 >