Re: [gentoo-dev] [PATCH 1/2] prefix.eclass: don't redundantly define EPREFIX as an eclass variable

[Benda Xu]

Sam James <sam@g.o> writes:

> Since EAPI 3, EPREFIX has been defined via PMS. Having this as an
> "eclass variable" in docs is confusing as it implies one needs
> prefix.eclass to provide it.
>
> Drop it given it adds nothing and causes confusion.
>
> Reported-by: Aaron W. Swenson <titanofold@g.o>
> Signed-off-by: Sam James <sam@g.o>
> ---
>  eclass/prefix.eclass | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/eclass/prefix.eclass b/eclass/prefix.eclass
> index 8d50d0ba7b6e..4a8c0e4ff15f 100644
> --- a/eclass/prefix.eclass
> +++ b/eclass/prefix.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2021 Gentoo Authors
> +# Copyright 1999-2022 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>
>  # @ECLASS: prefix.eclass
> @@ -20,18 +20,6 @@ esac
>  if [[ -z ${_PREFIX_ECLASS} ]]; then
>  _PREFIX_ECLASS=1
>
> -# @ECLASS_VARIABLE: EPREFIX
> -# @DESCRIPTION:
> -# The offset prefix of a Gentoo Prefix installation.  When Gentoo Prefix
> -# is not used, ${EPREFIX} should be "".  Prefix Portage sets EPREFIX,
> -# hence this eclass has nothing to do here in that case.
> -# Note that setting EPREFIX in the environment with Prefix Portage sets
> -# Portage into cross-prefix mode.
> -if [[ ! ${EPREFIX+set} ]]; then
> -	export EPREFIX=''
> -fi
> -
> -
>  # @FUNCTION: eprefixify
>  # @USAGE: <list of to be eprefixified files>
>  # @DESCRIPTION:

LGTM, thanks Sam!

Yours,
Benda