Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Alec Warner <antarus@g.o>
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/sandbox: ChangeLog sandbox-1.2.18.1-r1.ebuild
Date: Mon, 29 Oct 2007 12:02:47
Message-Id: 200710290757.25038.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/sandbox: ChangeLog sandbox-1.2.18.1-r1.ebuild by Alec Warner
1 On Thursday 18 October 2007, Alec Warner wrote:
2 > On 10/17/07, Doug Goldstein <cardoe@g.o> wrote:
3 > > Donnie Berkholz wrote:
4 > > > On 15:55 Wed 17 Oct , Daniel Drake (dsd) wrote:
5 > > >> 1.1 sys-apps/sandbox/sandbox-1.2.18.1-r1.ebuild
6 > > >>
7 > > >> file :
8 > > >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/sandbox/sandb
9 > > >>ox-1.2.18.1-r1.ebuild?rev=1.1&view=markup plain:
10 > > >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/sandbox/sandb
11 > > >>ox-1.2.18.1-r1.ebuild?rev=1.1&content-type=text/plain
12 > > >>
13 > > >> keepdir /var/log/sandbox
14 > > >> fowners root:portage /var/log/sandbox
15 > > >> fperms 0770 /var/log/sandbox
16 > > >>
17 > > >> cd ${S}
18 > > >> dodoc AUTHORS ChangeLog NEWS README
19 > > >> }
20 > > >>
21 > > >> pkg_preinst() {
22 > > >> chown root:portage ${D}/var/log/sandbox
23 > > >> chmod 0770 ${D}/var/log/sandbox
24 > > >> }
25 > > >
26 > > > How come you need to repeat the permissions like this?
27 > > >
28 > > > Also, quoting. =)
29 > > >
30 > > > Thanks,
31 > > > Donnie
32 > >
33 > > Also, pkg_preinst() is not binary package safe. So unless the portage
34 > > group is always the same gid on EVERY Gentoo box. This will break binary
35 > > packages.
36 >
37 > Eh?
38 >
39 > pkg_* runs for binpkgs...so depending on the target machine it will
40 > chown appropriately in $IMAGE and then merge to the livefs.
41 >
42 > If you build the binpkg on machine A and install it on B, pkg_preinst
43 > will run on both (once for the build and one for the install)
44
45 Alec is correct, this is perfectly binary safe. but people should forget he
46 ever said "$IMAGE" and pretend he said "$D" ;)
47 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature