Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] Eclass changes for cross-compiling Python modules
Date: Sat, 05 Jan 2019 00:07:11
Message-Id: 20190105000652.3436040f@symphony.aura-online.co.uk
In Reply to: Re: [gentoo-dev] [PATCH] Eclass changes for cross-compiling Python modules by "Michał Górny"
1 On Fri, 04 Jan 2019 17:03:42 +0100
2 Michał Górny <mgorny@g.o> wrote:
3
4 > On Thu, 2019-01-03 at 21:39 +0000, James Le Cuirot wrote:
5 > > Here's a series of eclass changes I've been working on since August to
6 > > allow Python modules to be cross-compiled. We previously believed this
7 > > to be practically impossible without significant changes upstream and
8 > > in the wider Python ecosystem so getting here feels like quite an
9 > > achievement. While the approach is a little unconventional, it doesn't
10 > > feel overly hacky and the results are quite consistently good.
11 > >
12 > > These changes should also benefit prefix and I did a full prefix
13 > > bootstrap for the first time this week just to make sure I didn't
14 > > break it.
15 > >
16 > > A handful of other Python packages that don't quite follow the usual
17 > > mantra have needed fixing up. I haven't included those changes here
18 > > but you can view them on this GitHub pull request.
19 > >
20 > > https://github.com/gentoo/gentoo/pull/9822
21 > >
22 > > Once this is in place, I can finish my long-awaited revamp of my
23 > > cross-boss project that will allow you to cross-compile @system from
24 > > scratch with very little effort.
25 > >
26 >
27 > I've reviewed a few commits but I think I had enough. If you really
28 > want to push this forward, please start by merging fixes into your
29 > previous commits because it's really not useful to have commits like
30 > 'fix bugs in commit 3 you've already reviewed'.
31
32 Sure, that's what I usually do.
33
34 > Then, you should seriously think how to make things simple. Because
35 > the eclass is very complex right now, and doubling the complexity for
36 > the sake of corner case of cross isn't going work for me. The last
37 > thing we need is more hacks on top of hacks to work around previous
38 > hacks.
39
40 I knew this was going to be a tough sell and I put it up on GitHub
41 first to get your initial feedback and keep you in the loop. Of course
42 I want to keep it simple, not least so it has a greater chance of being
43 accepted, but you should know better than most that this was never
44 going to be easy. As I said, we initially thought it was impossible.
45 I'll respond to your points so far on the list but we can take this
46 back to GitHub to avoid spamming everyone else.
47
48 --
49 James Le Cuirot (chewi)
50 Gentoo Linux Developer