Gentoo Archives: gentoo-dev

From: Hans de Graaff <graaff@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] ruby-ng.eclass: replace ebegin with einfo in _ruby_invoke_environment
Date: Sun, 10 Jul 2022 07:55:45
In Reply to: [gentoo-dev] [PATCH] ruby-ng.eclass: replace ebegin with einfo in _ruby_invoke_environment by Mike Gilbert
1 On Sun, 2022-07-03 at 15:45 -0400, Mike Gilbert wrote:
2 > Calling ebegin here makes no sense because it is likely that the
3 > called
4 > function will also generate output. This will lead to the "[ ok ]"
5 > potentially appearing many lines later.
6 >
7 > It also leads to nested ebegin calls, which make no sense for the
8 > same
9 > reason.
11 I looked at this earlier and left this in because it makes sense to me
12 to do it this way conceptually. That implies that our tools should
13 supported nested ebegin calls and deal with multiline output, so for me
14 the real issue to fix is there.
16 Right now that support isn't there, though, and if that isn't
17 forthcoming soonish I have no objections to this patch if people feel
18 that is the better approach (for now).
20 Hans


File name MIME type
signature.asc application/pgp-signature