Re: [gentoo-dev] cmake.eclass

[Panard]

Hi,

Thanks for your comments.

Here is my updated cmake.eclass :
http://backzone.net/~panard/patches/gentoo-overlay/eclass/cmake.eclass

Beers,

Panard


Le Mercredi 24 Mai 2006 02:52, Mike Frysinger a écrit :
> On Thursday 18 May 2006 07:44, Panard wrote:
> >         OPTION=${OPTION:-"WITH_${USEFLAG}"}
>
> quoting here is pointless
>
> >         mkdir -p ${BUILDDIR}
> >         cd ${BUILDDIR}
> >         echo cmake ${S} -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
> >                         $(cmake_use_option debug CMAKE_BUILD_TYPE
> > debugfull) $*
> > 		cmake ${S} -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
> >                         $(cmake_use_option debug CMAKE_BUILD_TYPE
> > debugfull) $*
>
> $BUILDDIR and $S should be quoted
>
> use "$@", not $*
>
> >         cd ${OLDPWD}
>
> if you want to enter a directory and then return to previous, use
> pushd/popd, not $OLDPWD
> -mike

-- 
HomePage: http://dev.inzenet.org/~panard/
Yzis : http://www.yzis.org
Qomics : http://dev.inzenet.org/~panard/qomics
Smileys : http://smileys.inzenet.org