Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Add distutils_enable_tests to ease testing

[Joonas Niilola]

Beautiful work, but is there a way to integrate "esetup.py test" into
this as well?


-- juippis


On 11/4/19 11:00 PM, Michał Górny wrote:
> Add a helpful function to handle adding common stuff for the most common
> test runners.
>
> Signed-off-by: Michał Górny <mgorny@g.o>
> ---
>  eclass/distutils-r1.eclass | 60 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
>
> Example ebuild use sent in replies.
>
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index d3eb8f22ead2..2edffdb2d7c5 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -232,6 +232,66 @@ fi
>  # }
>  # @CODE
>
> +# @FUNCTION: distutils_enable_tests
> +# @USAGE: <test-runner>
> +# @DESCRIPTION:
> +# Set up IUSE, RESTRICT, BDEPEND and python_test() for running tests
> +# with the specified test runner.  Also copies the current value
> +# of RDEPEND to test?-BDEPEND.  The test-runner argument must be one of:
> +#
> +# - nose: nosetests (dev-python/nose)
> +# - pytest: dev-python/pytest
> +# - unittest: for built-in Python unittest module
> +#
> +# This function is meant as a helper for common use cases, and it only
> +# takes care of basic setup.  You still need to list additional test
> +# dependencies manually.  If you have uncommon use case, you should
> +# not use it and instead enable tests manually.
> +#
> +# This function must be called in global scope, after RDEPEND has been
> +# declared.  Take care not to overwrite the variables set by it.
> +distutils_enable_tests() {
> +	debug-print-function ${FUNCNAME} "${@}"
> +	[[ ${#} -eq 1 ]] || die "${FUNCNAME} takes exactly one argument: test-runner"
> +
> +	[[ ${EAPI} == [56] ]] && local BDEPEND
> +
> +	IUSE+=" test"
> +	RESTRICT+=" !test? ( test )"
> +	BDEPEND+=" test? ("
> +
> +	case ${1} in
> +		nose)
> +			BDEPEND+=" dev-python/nose[${PYTHON_USEDEP}]"
> +			python_test() {
> +				nosetests -v || die "Tests fail with ${EPYTHON}"
> +			}
> +			;;
> +		pytest)
> +			BDEPEND+=" dev-python/pytest[${PYTHON_USEDEP}]"
> +			python_test() {
> +				pytest -vv || die "Tests fail with ${EPYTHON}"
> +			}
> +			;;
> +		unittest)
> +			python_test() {
> +				"${EPYTHON}" -m unittest discover -v ||
> +					die "Tests fail with ${EPYTHON}"
> +			}
> +			;;
> +		*)
> +			die "${FUNCNAME}: unsupported argument: ${1}"
> +	esac
> +
> +	BDEPEND+=" ${RDEPEND} )"
> +
> +	[[ ${EAPI} == [56] ]] && DEPEND+=" ${BDEPEND}"
> +
> +	# we need to ensure successful return in case we're called last,
> +	# otherwise Portage may wrongly assume sourcing failed
> +	return 0
> +}
> +
>  # @FUNCTION: esetup.py
>  # @USAGE: [<args>...]
>  # @DESCRIPTION: