1 |
>>>>> On Wed, 27 Nov 2019, Michał Górny wrote: |
2 |
|
3 |
> Update the skel variable order to place S immediately after SRC_URI. |
4 |
> This seems to be a growing trend, and is quite reasonable given that |
5 |
> S usually matches the archive name, and e.g. if SRC_URI uses MY_P, |
6 |
> then S usually uses it as well: |
7 |
|
8 |
> SRC_URI="http://example.com/${MY_P}.tar.gz" |
9 |
> S=${WORKDIR}/${MY_P} |
10 |
|
11 |
My only concern is that this doesn't match the grouping of variables |
12 |
in PMS. All other variables in these first blocks are ebuild-defined |
13 |
variables [1], whereas S is not. |
14 |
|
15 |
Ulrich |
16 |
|
17 |
[1] https://projects.gentoo.org/pms/7/pms.html#x1-590007 |