| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 25-04-2010 13:10, Petteri Räty wrote: |
| 5 |
> On 04/26/2010 01:42 AM, Alistair Bush wrote: |
| 6 |
>>> On 04/24/2010 09:14 PM, Alexis Ballier wrote: |
| 7 |
>>>> On Sat, 24 Apr 2010 20:40:54 +0300 |
| 8 |
>>>> |
| 9 |
>>>> Petteri Räty <betelgeuse@g.o> wrote: |
| 10 |
>>>>> 17:34 < Betelgeuse> robbat2|na: how easy to it to prevent commits to |
| 11 |
>>>>> CVS if the commit message doesn't match a certain pattern? |
| 12 |
>>>>> 17:36 <@robbat2|na> go and checkout the CVSROOT and there should be an |
| 13 |
>>>>> example there |
| 14 |
>>>>> 17:37 < Betelgeuse> robbat2|na: Ok so doable then. Thanks. |
| 15 |
>>>>> |
| 16 |
>>>>> What do you think about not allowing commits to eclasses without |
| 17 |
>>>>> mentioning an another developer who has reviewed and approved the diff |
| 18 |
>>>>> in the commit message? There's enough people on gentoo-dev for urgent |
| 19 |
>>>>> stuff too. |
| 20 |
>>>> |
| 21 |
>>>> no thanks; we already have the policy to require that major changes to |
| 22 |
>>>> broad impact eclasses have gone through -dev, no need to add more |
| 23 |
>>>> bureaucracy. |
| 24 |
>>> |
| 25 |
>>> But the policy is not tested by the quizzes and we have had cases lately |
| 26 |
>>> where large diffs have been committed without gentoo-dev review. With |
| 27 |
>>> peer review it's likely that the reviewer is familiar with what should |
| 28 |
>>> be sent to gentoo-dev as hesitant/new people won't give their approval |
| 29 |
>>> that easily. |
| 30 |
|
| 31 |
>> 2) Where is this policy recorded, and why does devmanual.g.o seem to |
| 32 |
>> (possibly) contradict it? [1] I'm not sure of the nature of the commits but |
| 33 |
>> were they non-general? |
| 34 |
>> |
| 35 |
> http://devmanual.gentoo.org/eclass-writing/index.html |
| 36 |
> |
| 37 |
> "Before updating eutils or a similar widely used eclass, it is best to |
| 38 |
> email the gentoo-dev list." |
| 39 |
|
| 40 |
The important bit there is "widely used eclass". I agree with having |
| 41 |
peer review, but as others argued I don't agree with the recent trend to |
| 42 |
make it increasingly harder to commit stuff to the tree. |
| 43 |
To expand on the above, by "widely used eclass" I interpret eutils, |
| 44 |
autotools, base and similar eclasses because even though some eclasses |
| 45 |
like the kde4 eclasses are used by many ebuilds, it's mostly a team's |
| 46 |
eclass and not a general eclass shared by everyone. |
| 47 |
|
| 48 |
- -- |
| 49 |
Regards, |
| 50 |
|
| 51 |
Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org |
| 52 |
Gentoo- forums / Userrel / Devrel / KDE / Elections |
| 53 |
-----BEGIN PGP SIGNATURE----- |
| 54 |
Version: GnuPG v2.0.15 (GNU/Linux) |
| 55 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ |
| 56 |
|
| 57 |
iQIcBAEBAgAGBQJL1F5OAAoJEC8ZTXQF1qEPNf4QAIoyr8IELeixBJDHvv2ACaMw |
| 58 |
omUQj5nbjFB1Xc7Die4dT7TkUfJ2/QddMcG1I/CNTNEdRtJAR31UDS2Lbm7gOj11 |
| 59 |
wpd+g7mDQuJZdW3873YXkThoynqS3xzfpZocxb2s+adxyXF6Mh65+N+ZT515HMh8 |
| 60 |
DujqxGHxjA4Cqn/zGe6ClqfRwxfGZkYkA/eQfX9m7TSJHTwxK4sijhFNphSsA89E |
| 61 |
qyVW0Y18mrf0pVBpUaQ4kfCuwp0HWOIoubSCIo47KFINfL4TteaX1NTOP9JzEIDH |
| 62 |
saCUURHQw2nWTsPDNjvL6euvriyTZpm0lhHR86j87maDVeGFDn0PZ8Cs/ypCVhxJ |
| 63 |
1MxdL7NvyUptHO6UGUvluqZzh4zTDEsotCRWzyshEPAy51q+rWbMLPVeDZfkVgl8 |
| 64 |
/0VlhNFgdoxuowOEK4AiTWifp5oa5RO03K5Hyfze2IfFXArva7Znb5oCGeHoEBqn |
| 65 |
Kr5trpgIqyW+v3XifurbuOSoU7BDTlzH3WrkCRJq0pP5Hogtod0wf1tAy/wQ+F+3 |
| 66 |
yUphi3tzMFMlFoqBE5pfjyTa22vi/RjNVgH3sie6HD8qZsmKJIILb2Y3NrloCzlB |
| 67 |
WYdCP0+dfFOafqFMpAFUuI3E7zrKacQK7mshLE9vTNa+dh6LVASn2WIaLdtse1GK |
| 68 |
sUN2ESxQteslTvu7v6r/ |
| 69 |
=GLm6 |
| 70 |
-----END PGP SIGNATURE----- |
Archives